[jboss-jira] [JBoss JIRA] (DROOLS-5046) [DMN Designer] Marshalling questions

[Edson Tirelli (Jira)]

    [ https://issues.redhat.com/browse/DROOLS-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972989#comment-13972989 ] 

Edson Tirelli commented on DROOLS-5046:
---------------------------------------

[~manstis] IMO, setting the "id" attribute for the elements is not a problem, and eventually might help with debugging as it is usually used as key to reference to elements within a DMN model. So, I would still set them.

All other optional attributes you listed above should not be set, unless explicitly set by the user in the model itself. 

Also, good catch on Rule Annotation. 

> [DMN Designer] Marshalling questions
> ------------------------------------
>
>                 Key: DROOLS-5046
>                 URL: https://issues.redhat.com/browse/DROOLS-5046
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>    Affects Versions: 7.33.0.Final
>            Reporter: Michael Anstis
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: drools-tools
>
> Our marshaller is EXPLICITLY setting Definitions.typeLanguage to FEEL. Is this acceptable? 
> DMN1.2 Specification "6.3.2 Definitions metamodel" states :
> An instance of Definitions MAY specify a typeLanguage, which is a URI that identifies the default type language used in elements within the scope of this Definitions ... If unspecified, the default typeLanguage is FEEL.
> So it is not wrong, but it is not necessary.
> ---------------------------------------------------------------------------------
> Our marshaller is EXPLICITLY setting ItemDefinition.id
> DMN1.2 Specification "7.3.2 - ItemDefinition metamodel" states :
> ...an instance of ItemDefinition HAS a name and an OPTIONAL id
> So it is not wrong, but it is not necessary.
> ---------------------------------------------------------------------------------
> Our marshaller IS NOT setting ContextEntry.id
> DMN1.2 Specification 10.5.2 - ContextEntry metamodel states :
> ...ContextEntry is a specialization of DMNElement, from which it INHERITS the OPTIONAL id...
> It is therefore correct for us to exclude the id (but _other tools_ includes it. Is that wrong?!)
> ---------------------------------------------------------------------------------
> Our marshaller is EXPLICITLY setting DecisionTable.preferredOrientation (to Rule-as-Row)
> DMN1.2 Specification 8.3.1 - Decision Table metamodel states :
> ...It has a preferredOrientation, which SHALL be one of the enumerated DecisionTableOrientation.
> It is therefore not wrong for us to include preferredOrientation and seems mandatory.
> ---------------------------------------------------------------------------------
> Our marshaller is EXPLICITLY setting inputExpression.id.
> DMN1.2 Specification 8.3.2 - Decision Table Input and Output metamodel:-
> ...An instance of InputClause is made of an optional inputExpression... [where an inputExpression is an Expression]. 
> There is not mention as to whether the Expression inherits its id or needs one explicitly defined.
> Is it therefore incorrect for us to include the id? 
> ---------------------------------------------------------------------------------
> Our marshaller IS NOT setting outputEntry.expressionLanguage.
> DMN1.2 Specification 8.3.2 - Decision Table Input and Output metamodel states (well does NOT state anything!) :
> OutputClause does not appear to have an expressionLanguage property; only the UnaryTests that is encapsulated by OutputClause supports it.
> Is this an issue with _other tools_'s marshaller?
> ---------------------------------------------------------------------------------
> [DMN Designer] Marshaller does not support DMN1.2 DecisionTable RuleAnnotation 
> https://issues.redhat.com/browse/DROOLS-5045



--
This message was sent by Atlassian Jira
(v7.13.8#713008)