[jboss-jira] [JBoss JIRA] (WFWIP-306) Health check response contains default readiness data

[Fabio Burzigotti (Jira)]

     [ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Burzigotti updated WFWIP-306:
-----------------------------------
    Steps to Reproduce: 
# download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1 

# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git at github.com:jmesnil/wildfly.git
$ cd wildfly 
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install 
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}

# clone the reproducer repository [2] and run the tests
{code}
$ git clone git at github.com:fabiobrz/health-22-repro.git

$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1

# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}

[1]
https://github.com/jmesnil/wildfly

[2]
https://github.com/fabiobrz/health-22-repro

  was:
# download and extract Wildfly 19 Beta 1 binaries into ~/wfly-19-beta-1 

# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git at github.com:jmesnil/wildfly.git
$ cd wildfly 
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install 
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}

# clone the reproducer repository [2] and run the tests
{code}
$ git clone git at github.com:fabiobrz/health-22-repro.git

$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1

# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}

[1]
https://github.com/jmesnil/wildfly

[2]
https://github.com/fabiobrz/health-22-repro



> Health check response contains default readiness data
> -----------------------------------------------------
>
>                 Key: WFWIP-306
>                 URL: https://issues.redhat.com/browse/WFWIP-306
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP Health
>            Reporter: Fabio Burzigotti
>            Assignee: Jeff Mesnil
>            Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         },
>         {
>             "name": "ready-deployment.HealthTest.war",
>             "status": "UP"
>         }
>     ]
> }
> //live
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         }
>     ]
> }
> //ready
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "ready-deployment.HealthTest.war",
>             "status": "UP"
>         }
>     ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         }
>     ]
> }
> //live
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         }
>     ]
> }
> //ready
> {
>     "status": "UP",
>     "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly



--
This message was sent by Atlassian Jira
(v7.13.8#713008)