[jboss-jira] [JBoss JIRA] (WFWIP-306) Health check response contains default readiness data

[Jeff Mesnil (Jira)]

    [ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977228#comment-13977228 ] 

Jeff Mesnil edited comment on WFWIP-306 at 2/20/20 4:47 AM:
------------------------------------------------------------

This change is mentioned in the document: https://github.com/wildfly/wildfly-proposals/blob/dc28a32e484667452e5766fc798907fbd7566a83/microprofile/WFLY-13048_upgrade_microprofile-health_2.2.adoc#non-requirements

It was added to fix WFLY-12952 that was done in 19.0.0.Beta2. It is *not* related to the MP Health 2.2 upgrade.


was (Author: jmesnil):
This change is mentioned in the document: https://github.com/wildfly/wildfly-proposals/blob/dc28a32e484667452e5766fc798907fbd7566a83/microprofile/WFLY-13048_upgrade_microprofile-health_2.2.adoc#non-requirements

It was added to fix WFLY-12952 that was done in 19.0.0.Beta2. It is *not* related to the MP Health 2.2 upgrade.

As documented in the WildFly documentation, you can set mp.health.disable-default-procedures to true to keep the previous behaviour

> Health check response contains default readiness data
> -----------------------------------------------------
>
>                 Key: WFWIP-306
>                 URL: https://issues.redhat.com/browse/WFWIP-306
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP Health
>            Reporter: Fabio Burzigotti
>            Assignee: Jeff Mesnil
>            Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no _readiness_ health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> The same _does not_ happen when there's just one registered readiness procedure - i.e. when no annotated _liveness_ procedures exist.
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> The following example uses an Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         },
>         {
>             "name": "ready-deployment.HealthTest.war",
>             "status": "UP"
>         }
>     ]
> }
> //live
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         }
>     ]
> }
> //ready
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "ready-deployment.HealthTest.war",
>             "status": "UP"
>         }
>     ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         }
>     ]
> }
> //live
> {
>     "status": "UP",
>     "checks": [
>         {
>             "name": "live",
>             "status": "UP",
>             "data": {
>                 "key": "value"
>             }
>         }
>     ]
> }
> //ready
> {
>     "status": "UP",
>     "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly



--
This message was sent by Atlassian Jira
(v7.13.8#713008)