[jboss-jira] [JBoss JIRA] (DROOLS-5060) [DMN Designer] Editor allows node with prefix/trailing space

[Jozef Marko (Jira)]

     [ https://issues.redhat.com/browse/DROOLS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jozef Marko updated DROOLS-5060:
--------------------------------
    Description: 
I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.

But, imho, an UX point is not being considered, where is necessary instead.

By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.

Further, I consider is just the Analyst which slipped a space.

In my perspective, the editor should just strip away the prefix/trailing space:
* -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062])
* While editing a DRGElement and hitting OK to save its name

For your consideration, thanks.

h2. Manual acceptance test
- Rename a node, check undo/redo
- Rename node as ctrl-c/ctrl+v
- Try to use \tab in the middle of the name
- Leading space
- Trailing space
- Save and reopen
- Documentation tab
- Rename via node popup
- Rename via properties panel
- Rename via expression grid - where applicable

  was:
I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.

But, imho, an UX point is not being considered, where is necessary instead.

By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.

Further, I consider is just the Analyst which slipped a space.

In my perspective, the editor should just strip away the prefix/trailing space:
* -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062])
* While editing a DRGElement and hitting OK to save its name

For your consideration, thanks.



> [DMN Designer] Editor allows node with prefix/trailing space
> ------------------------------------------------------------
>
>                 Key: DROOLS-5060
>                 URL: https://issues.redhat.com/browse/DROOLS-5060
>             Project: Drools
>          Issue Type: Bug
>          Components: DMN Editor
>            Reporter: Matteo Mortari
>            Assignee: Michael Anstis
>            Priority: Major
>              Labels: drools-tools
>         Attachments: ItemDefinition-white-space.png
>
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062])
> * While editing a DRGElement and hitting OK to save its name
> For your consideration, thanks.
> h2. Manual acceptance test
> - Rename a node, check undo/redo
> - Rename node as ctrl-c/ctrl+v
> - Try to use \tab in the middle of the name
> - Leading space
> - Trailing space
> - Save and reopen
> - Documentation tab
> - Rename via node popup
> - Rename via properties panel
> - Rename via expression grid - where applicable



--
This message was sent by Atlassian Jira
(v7.13.8#713008)