[jboss-jira] [JBoss JIRA] (WFLY-12925) MP FT retry.callsSucceededRetried.total metric has wrong value

[Ivan Straka (Jira)]

Ivan Straka created WFLY-12925:
----------------------------------

             Summary: MP FT retry.callsSucceededRetried.total metric has wrong value
                 Key: WFLY-12925
                 URL: https://issues.redhat.com/browse/WFLY-12925
             Project: WildFly
          Issue Type: Bug
          Components: MP Fault Tolerance
    Affects Versions: 19.0.0.Beta1
            Reporter: Ivan Straka
            Assignee: Radoslav Husar


When method annotated with @Fallback and @Retry fails, MP FT retry.callsSucceededRetried.total metric even though the method fails everytime and falls into a fallback method.

The issue is only in the metric. The method is retried as expected and fallback method is invoked only once as expected.

*Reproducer:*
https://github.com/istraka/eap-microprofile-test-suite/blob/mp-ft-metrics-reproducer/microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/integration/Reproducers.java#L76

*CDI Bean:*
{code:java}
    @Fallback(fallbackMethod = "isReadyFallback")
    @Retry(maxRetries = MAX_RETRIES)
    public boolean isReady() throws IOException {
        service.simulateOpeningResources();
        return ready.get();
    }

    public boolean isReadyFallback() {
        return readyInMainenance.get();
    }

    @Counted(name = "simulation-count", absolute = true, displayName = "Simulation Count", description = "Number of simulateOpeningResources invocations", reusable = true)
    public void simulateOpeningResources() throws IOException {
        if (inMaintanance.get()) {
            throw new IOException("In maintanance");
        }
    }
{code}

https://github.com/istraka/eap-microprofile-test-suite/blob/mp-ft-metrics-reproducer/microprofile-health/src/main/java/org/jboss/eap/qe/microprofile/health/integration/FailSafeDummyService.java#L47

*Smallrye issue*
https://github.com/smallrye/smallrye-fault-tolerance/issues/159



--
This message was sent by Atlassian Jira
(v7.13.8#713008)