[jboss-jira] [JBoss JIRA] (JGRP-2429) MsgStats num_bytes_sent should be incremented by the Message::size

[Bela Ban (Jira)]

     [ https://issues.redhat.com/browse/JGRP-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban updated JGRP-2429:
---------------------------
    Fix Version/s: 4.1.9


I don't like this; num_bytes is always the number of bytes sent *in the payload* of a message. If you want the entire marshalled size of a message, I suggest introduce a new field.
Method {{size()}} can be quite costly to compute (especially with other message types in 5.0), so -1 from me for using this in the transport.
If needed, add this to the {{STATS}} protocol.

> MsgStats num_bytes_sent should be incremented by the Message::size
> ------------------------------------------------------------------
>
>                 Key: JGRP-2429
>                 URL: https://issues.redhat.com/browse/JGRP-2429
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 4.1.8
>            Reporter: Diego Lovison
>            Assignee: Diego Lovison
>            Priority: Major
>             Fix For: 4.1.9
>
>
> MsgStats num_bytes_sent should be incremented by the Message::size
> Today it is incremented by the Message:length that is the length of the payload, it doesn't include the headers.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)