[jboss-jira] [JBoss JIRA] (WFWIP-291) Log messages from io.smallrye.openapi don't have message ID

[Darran Lofthouse (Jira)]

    [ https://issues.redhat.com/browse/WFWIP-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942415#comment-13942415 ] 

Darran Lofthouse commented on WFWIP-291:
----------------------------------------

Additionally there is also a general issue in that we can not impose our own logging formats on third party projects pulled into WildFly.

If a third party project throws an Exception we can catch we may have an opportunity to catch and log with an ID or rethrow with an ID but we don't have options to intercept messages directly logged.

Having said that it does seem SmallRye will be receptive to having support added to internatinalised messages with IDs but as with the comment from Paul this would not cover messages at debug or trace level.


> Log messages from io.smallrye.openapi don't have message ID
> -----------------------------------------------------------
>
>                 Key: WFWIP-291
>                 URL: https://issues.redhat.com/browse/WFWIP-291
>             Project: WildFly WIP
>          Issue Type: Bug
>          Components: MP OpenAPI
>            Reporter: Fabio Burzigotti
>            Assignee: Paul Ferraro
>            Priority: Major
>
> Messages logged by io.smallrye.openapi don't have assigned ID:
> {code}
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.util.SchemaFactory] (MSC service thread 1-4) Processing a single @Schema annotation.
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner] (MSC service thread 1-4) Processing a single @Response annotation.
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner] (MSC service thread 1-4) Processing jax-rs method: {0}
> 2020-01-05 16:58:49,225 DEBUG [io.smallrye.openapi.runtime.scanner.OpenApiDataObjectScanner] (MSC service thread 1-4) Starting processing with root: java.lang.String
> {code}
> A search in SmallRye implementation seems to show that IDs are not used even when level is WARN:
> {code}
> $ find . -name '*.*' -type f -print0 | xargs -0 grep --color -n -e 'LOG.warn'
> ./implementation/src/main/java/io/smallrye/openapi/runtime/scanner/ParameterProcessor.java:551:                        LOG.warnf("Matrix parameter references missing path segment: %s", segmentName);
> ./implementation/src/main/java/io/smallrye/openapi/runtime/scanner/ParameterProcessor.java:1147:            LOG.warnf("Value '%s' is not a valid %s default", stringValue, primitive.name().toLowerCase());
> {code}



--
This message was sent by Atlassian Jira
(v7.13.8#713008)