[jboss-jira] [JBoss JIRA] (DROOLS-4698) Adding "expression" type handling for Collection type propereties

Yeser Amer (Jira) issues at jboss.org
Thu Jan 9 11:27:54 EST 2020


    [ https://issues.redhat.com/browse/DROOLS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945038#comment-13945038 ] 

Yeser Amer edited comment on DROOLS-4698 at 1/9/20 11:26 AM:
-------------------------------------------------------------

[~jomarko]
Comment 1: Issue present in master and not related to this PR. Can you please open  a new ticket?
Comment 2: (not tested in master) in my opinion same of comment 1
Comment 3: 1. Inside the expression I see "Free Rooms", which is not a valid expression
                       3. you need to compare the FEEL list with the value definied in GIVEN in this way --->" ? = [{Capacity : 1, Price : 1500}, {Capacity : 1, Price : 1200}] "
                           "?" represents the actualValue.
Comment 4: I changed part of the code during code review, then it seems no more present. BUT if you try to open a duplicated ExpressionCollection cell, an exception is thrown. I need to fix that. I'll notify you when is fixed.

Thank you!


was (Author: yamer):
Comment 1: Issue present in master and not related to this PR. Can you please open  a new ticket?
Comment 2: (not tested in master) in my opinion same of comment 1
Comment 3: 1. Inside the expression I see "Free Rooms", which is not a valid expression
                       3. you need to compare the FEEL list with the value definied in GIVEN in this way --->" ? = [{Capacity : 1, Price : 1500}, {Capacity : 1, Price : 1200}] "
                           "?" represents the actualValue.
Comment 4: I changed part of the code during code review, then it seems no more present. BUT if you try to open a duplicated ExpressionCollection cell, an exception is thrown. I need to fix that. I'll notify you when is fixed.

Thank you!

> Adding "expression" type handling for Collection type propereties
> -----------------------------------------------------------------
>
>                 Key: DROOLS-4698
>                 URL: https://issues.redhat.com/browse/DROOLS-4698
>             Project: Drools
>          Issue Type: Feature Request
>          Components: Scenario Simulation and Testing
>            Reporter: Yeser Amer
>            Assignee: Yeser Amer
>            Priority: Major
>              Labels: UX, UXTeam, drools-tools
>         Attachments: Screenshot from 2020-01-08 14-14-05.png, Screenshot from 2020-01-08 14-20-30.png, Screenshot from 2020-01-08 14-36-33.png, Screenshot from 2020-01-08 14-36-52.png, test urgent.scesim, urgent.dmn
>
>
> Support is about both drools/java collections and dmn collections.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)


More information about the jboss-jira mailing list