[jboss-jira] [JBoss JIRA] (WFLY-12971) SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish

[Rostislav Svoboda (Jira)]

     [ https://issues.redhat.com/browse/WFLY-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rostislav Svoboda moved WFWIP-130 to WFLY-12971:
------------------------------------------------

        Project: WildFly  (was: WildFly WIP)
            Key: WFLY-12971  (was: WFWIP-130)
    Component/s: MP Metrics
                     (was: MP Metrics)


> SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish
> --------------------------------------------------------------------------------
>
>                 Key: WFLY-12971
>                 URL: https://issues.redhat.com/browse/WFLY-12971
>             Project: WildFly
>          Issue Type: Bug
>          Components: MP Metrics
>            Reporter: Rostislav Svoboda
>            Assignee: Jeff Mesnil
>            Priority: Major
>
> SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish
> https://github.com/smallrye/smallrye-metrics/blob/master/implementation/src/main/java/io/smallrye/metrics/JmxWorker.java#L156
>  - iterate entrySet instead of keySet
>  - can it happen that there are more entries with value '*' ?
>  - shouldn't the for cycle end when the (first?) match is found ?



--
This message was sent by Atlassian Jira
(v7.13.8#713008)