[jboss-jira] [JBoss JIRA] (WFCORE-255) Boot time only system properties should not modify the runtime only the model

[James Perkins (Jira)]

    [ https://issues.redhat.com/browse/WFCORE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961316#comment-13961316 ] 

James Perkins commented on WFCORE-255:
--------------------------------------

I'll try to think of a better title. I could go either way with it being a feature. I know when I had a look it wasn't a simple task to allow these properties to be defined as system properties. The issue there is no way to override these properties for a server within domain, but it can be done for standalone servers. It's been like this from the start. Maybe it's intentional and we can just accept in which case I'm completely fine with closing this issue.

> Boot time only system properties should not modify the runtime only the model
> -----------------------------------------------------------------------------
>
>                 Key: WFCORE-255
>                 URL: https://issues.redhat.com/browse/WFCORE-255
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Management
>            Reporter: James Perkins
>            Assignee: James Perkins
>            Priority: Major
>              Labels: domain-mode, downstream_dependency
>
> The three properties {{jboss.server.base.dir}}, {{jboss.server.config.dir}} and {{jboss.server.log.dir}} are allowed to be overridden for servers. For a domain server, these values need to be allowed to be set as a {{boot-time=true}} system property. 
> These properties should also be allowed to be set as a system-property resource or overridden via {{JAVA_OPTS}} or the {{launch-command}}. 
> The {{add}}, {{write-attribute}} and {{remove}} operations should not modify the runtime, but should modify the model. It's debatable whether the server should be put in a {{restart-required}} state. Currently similar resources do _not_ set the server state to {{restart-required}}. For now we should stick with the same state.
> {code}
> [domain at localhost:9999 /] /host=master/system-property=jboss.server.log.dir:add(boot-time=true,value="/var/log")
> {
>     "outcome" => "failed",
>     "result" => undefined,
>     "failure-description" => "JBAS010839: Operation failed or was rolled back on all servers.",
>     "rolled-back" => true,
>     "server-groups" => {"main-server-group" => {"host" => {"master" => {
>         "server-one" => {"response" => {
>             "outcome" => "failed",
>             "failure-description" => "JBAS015845: System property jboss.server.log.dir cannot be set via the xml configuration file or from a management client; it's value must be known at initial process start so it can only set from the commmand line",
>    
>          "rolled-back" => true
>         }},
>         "server-two" => {"response" => {
>             "outcome" => "failed",
>             "failure-description" => "JBAS015845: System property jboss.server.log.dir cannot be set via the xml configuration file or from a management client; it's value must be known at initial process start so it can only set from the commmand line",
>             "rolled-back" => true
>         }}
>     }}}}
> }
> {code}
> These properties should also be allowed to be set in the {{/host=\*/server-config=\*/jvm=\*/}} resource on the {{jvm-options}} and likely {{launch-command}} attributes.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)