[jboss-jira] [JBoss JIRA] (WFCORE-255) jboss.server.base.dir, jboss.server.config.dir and jboss.server.log.dir should also be allowed to be set as a system-property resource or overridden via JAVA_OPTS or the launch-command.

[Brian Stansberry (Jira)]

    [ https://issues.redhat.com/browse/WFCORE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961442#comment-13961442 ] 

Brian Stansberry commented on WFCORE-255:
-----------------------------------------

It was intentional. It's just a limitation because we can't do everything and chose not to implement support for this.

Perhaps it's just an Enhancement instead of a Feature Request, if there is no new API, just that existing resources will accept values they would not have before.

But, I suspect that is not the case, or if it is the case the appropriate work to do it correctly, i.e. analysis, test coverage and docs is basically the same as a feature so might as well handle it as such.

For example, system properties can be set at numerous levels, but for these properties some levels likely are wrong. That all has to be analyzed and documented and perhaps it means the configuration style to use for this is not system properties but is something else that we can properly restrict.

> jboss.server.base.dir, jboss.server.config.dir and jboss.server.log.dir  should also be allowed to be set as a system-property resource or overridden via JAVA_OPTS or the launch-command. 
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-255
>                 URL: https://issues.redhat.com/browse/WFCORE-255
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Management
>            Reporter: James Perkins
>            Assignee: James Perkins
>            Priority: Major
>              Labels: domain-mode, downstream_dependency
>
> The three properties {{jboss.server.base.dir}}, {{jboss.server.config.dir}} and {{jboss.server.log.dir}} are allowed to be overridden for servers. For a domain server, these values need to be allowed to be set as a {{boot-time=true}} system property. 
> These properties should also be allowed to be set as a system-property resource or overridden via {{JAVA_OPTS}} or the {{launch-command}}. 
> The {{add}}, {{write-attribute}} and {{remove}} operations should not modify the runtime, but should modify the model. It's debatable whether the server should be put in a {{restart-required}} state. Currently similar resources do _not_ set the server state to {{restart-required}}. For now we should stick with the same state.
> {code}
> [domain at localhost:9999 /] /host=master/system-property=jboss.server.log.dir:add(boot-time=true,value="/var/log")
> {
>     "outcome" => "failed",
>     "result" => undefined,
>     "failure-description" => "JBAS010839: Operation failed or was rolled back on all servers.",
>     "rolled-back" => true,
>     "server-groups" => {"main-server-group" => {"host" => {"master" => {
>         "server-one" => {"response" => {
>             "outcome" => "failed",
>             "failure-description" => "JBAS015845: System property jboss.server.log.dir cannot be set via the xml configuration file or from a management client; it's value must be known at initial process start so it can only set from the commmand line",
>    
>          "rolled-back" => true
>         }},
>         "server-two" => {"response" => {
>             "outcome" => "failed",
>             "failure-description" => "JBAS015845: System property jboss.server.log.dir cannot be set via the xml configuration file or from a management client; it's value must be known at initial process start so it can only set from the commmand line",
>             "rolled-back" => true
>         }}
>     }}}}
> }
> {code}
> These properties should also be allowed to be set in the {{/host=\*/server-config=\*/jvm=\*/}} resource on the {{jvm-options}} and likely {{launch-command}} attributes.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)