[jboss-jira] [JBoss JIRA] (JGRP-2273) ASYM_ENCRYPT: deprecate encrypt_entire_message

[Dennis Reed (Jira)]

    [ https://issues.redhat.com/browse/JGRP-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753123#comment-13753123 ] 

Dennis Reed edited comment on JGRP-2273 at 7/16/20 10:44 PM:
-------------------------------------------------------------

<SERIALIZE/>
<ASYM_ENCRYPT/>

Isn't that backwards?
The message would need to be serialized before it gets to ASYM_ENCRYPT.  Otherwise SERIALIZE will only be obfuscating the data a bit.



> ASYM_ENCRYPT: deprecate encrypt_entire_message
> ----------------------------------------------
>
>                 Key: JGRP-2273
>                 URL: https://issues.redhat.com/browse/JGRP-2273
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>            Priority: Major
>             Fix For: 4.1.3
>
>
> In {{ASYM_ENCRYPT}}, {{encrypt_entire_message}} encrypts not only the payload, but also metadata such as destination and sender's address, headers and flags.
> The rationale was to prevent replay attacks. However, this is not an issue, as replayed messages will simply get dropped by the retransmission layer (e.g. NAKACK2 or UNICAST3).
> If people still want this feature, they can write a protocol _above_ {{ASYM_ENCRYPT}}, which serializes the entire message into the payload of a new message, and this would be exactly the same as setting {{encrypt_entire_message}} to {{true}}.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)