[jboss-jira] [JBoss JIRA] (WFLY-13575) Remove all hard coded references to Artemis default values

[Michal Petrov (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252521#comment-14252521 ] 

Michal Petrov commented on WFLY-13575:
--------------------------------------

[~ehugonnet] as far as I can see there was only one hard-coded reference and that's being fixed in WFLY-13063. I wrote a test for the attributes that had a reference to Artemis and there are a few mismatches:
 * CommonAttributes.BRIDGE_CONFIRMATION_WINDOW_SIZE (this one is being fixed)
 * ServerDefinition.GLOBAL_MAX_DISK_USAGE (100 vs 90)
 * ServerDefinition.GLOBAL_MAX_MEMORY_SIZE (-1 vs "Runtime.getRuntime().maxMemory() / 2")
 * ServerDefinition.JOURNAL_POOL_FILES (10 vs -1)

then there are a few such as {{ServerDefinition.JOURNAL_JDBC_LOCK_EXPIRATION}} where the value is technically the same but in different units (seconds/milliseconds) 

> Remove all hard coded references to Artemis default values
> ----------------------------------------------------------
>
>                 Key: WFLY-13575
>                 URL: https://issues.redhat.com/browse/WFLY-13575
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: JMS
>    Affects Versions: 20.0.0.Final
>            Reporter: Emmanuel Hugonnet
>            Assignee: Michal Petrov
>            Priority: Major
>
> There are still attributes that use Artemis default configuration valuues from FileConfiguration for example.
> Remove those values so that they are not updated behind the scene and add a test to know when our default values don't align with Artemis ones.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)