[jboss-jira] [JBoss JIRA] (WFCORE-5067) Wildfly as Windows Service fails to stop in a timely fashion

[Cedric HENRY (Jira)]

    [ https://issues.redhat.com/browse/WFCORE-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310818#comment-14310818 ] 

Cedric HENRY edited comment on WFCORE-5067 at 7/28/20 8:52 AM:
---------------------------------------------------------------

While further investigating the issue in matter after documenting my assumption in the comment mentioned in the description, I have discovered in the _wildfly-stderr.2020-07-28.log_ file from server the following message:
{noformat}
2020-07-28 13:03:48 Commons Daemon procrun stderr initialized
" was unexpected at this time.{noformat}
which matches an attempt in stopping the Wildfly windows service.

Hence, I have looked into _service.bat_ (under _%JBOSS_HOME%\bin\service_) and I have observed the difference of formatting between STARTPARAM and STOPPARAM, as well as the [PROCRUN|https://commons.apache.org/proper/commons-daemon/procrun.html] documentation, and the fact _jboss-cli.bat_ is apparently not called on service stop...

 Looking into this, I have worked out a solution tested on the standalone configuration with WIldfly 10.1.0.Final.
h2. The Solution

STOPPARAM must not use the " character (as mentioned in the error message above), thus shall be formatted otherwise
 * *For Standalone Configuration:*

On line 475 of the service.bat script
{code:java}
set STOPPARAM=/c#!STOP_SCRIPT!#--controller=%CONTROLLER%#--connect#--command=:shutdown%CREDENTIALS%
{code}
 * *For Domain Configuration:*

On line 469 of the service.bat script (not tested though)
{code:java}
 set STOPPARAM=/c#%STOP_SCRIPT%#--controller=%CONTROLLER%#--connect#--command=/host=!DC_HOST!:shutdown%CREDENTIALS%{code}
 

 *Note* that this implies having {{CREDENTIALS}} formatted as follow when set (line 444):
{code:java}
CREDENTIALS=#--user=%JBOSSUSER%#--password=%JBOSSPASS%{code}


was (Author: cedric-henry):
While further investigating the issue in matter after the documenting my assumption in the comment mentioned in the description, I have discovered in the _wildfly-stderr.2020-07-28.log_ file from server the following message:
{noformat}
2020-07-28 13:03:48 Commons Daemon procrun stderr initialized
" was unexpected at this time.{noformat}
which matches an attempt in stopping the Wildfly windows service.

Hence, I have looked into _service.bat_ (under _%JBOSS_HOME%\bin\service_) and I have observed the difference of formatting between STARTPARAM and STOPPARAM, as well as the [PROCRUN|https://commons.apache.org/proper/commons-daemon/procrun.html] documentation, and the fact _jboss-cli.bat_ is apparently not called on service stop...

 Looking into this, I have worked out a solution tested on the standalone configuration with WIldfly 10.1.0.Final.
h2. The Solution

STOPPARAM must not use the " character (as mentioned in the error message above), thus shall be formatted otherwise
 * *For Standalone Configuration:*

On line 475 of the service.bat script
{code:java}
set STOPPARAM=/c#!STOP_SCRIPT!#--controller=%CONTROLLER%#--connect#--command=:shutdown%CREDENTIALS%
{code}
 * *For Domain Configuration:*

On line 469 of the service.bat script (not tested though)
{code:java}
 set STOPPARAM=/c#%STOP_SCRIPT%#--controller=%CONTROLLER%#--connect#--command=/host=!DC_HOST!:shutdown%CREDENTIALS%{code}
 

 *Note* that this implies having {{CREDENTIALS}} formatted as follow when set (line 444):
{code:java}
CREDENTIALS=#--user=%JBOSSUSER%#--password=%JBOSSPASS%{code}

> Wildfly as Windows Service fails to stop in a timely fashion
> ------------------------------------------------------------
>
>                 Key: WFCORE-5067
>                 URL: https://issues.redhat.com/browse/WFCORE-5067
>             Project: WildFly Core
>          Issue Type: Bug
>            Reporter: Cedric HENRY
>            Assignee: Jeff Mesnil
>            Priority: Major
>
> As already discussed under WFCORE-1719, there a problem when stopping the 'Wildfly' Windows service resulting in error dialog about the service not stopping in a timely fashion.
> Further details got also provided in the comment https://issues.redhat.com/browse/WFCORE-1719?focusedCommentId=14310623&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14310623



--
This message was sent by Atlassian Jira
(v7.13.8#713008)