[jboss-jira] [JBoss JIRA] (WFCORE-4916) Unclear attribute name completion for LIST type

[Brian Stansberry (Jira)]

    [ https://issues.redhat.com/browse/WFCORE-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128334#comment-14128334 ] 

Brian Stansberry commented on WFCORE-4916:
------------------------------------------

This seems like an enhancement. Prompting with both '[' and ',' would be better IMHO than completing with '['. The '[' is a valid option but it's not the only one and not even the most likely one.

That said,  I don't believe we complete with a ',' when people hit tab after other non-complex attribute names. If we start completing/prompting with a ',' in some cases it should be done in all cases. Which starts to get into the Enhancement territory.

> Unclear attribute name completion for LIST type
> -----------------------------------------------
>
>                 Key: WFCORE-4916
>                 URL: https://issues.redhat.com/browse/WFCORE-4916
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 12.0.0.Beta1
>            Reporter: Chao Wang
>            Assignee: Jean Francois Denise
>            Priority: Minor
>
> Following discussion in WFCORE-4908. There is a completion of "[" for LIST type attribute name after hitting tab, for example:
> {code}
> [domain at localhost:9990 /] /host=master/server-config=server-one/jvm=default:write-attribute(name=jvm-options
> {code}
> added here https://github.com/wildfly/wildfly-core/blob/12.0.0.Beta1/cli/src/main/java/org/jboss/as/cli/impl/AttributeNamePathCompleter.java#L351-L355
> It seems to me that misleads to the wrong syntax as described in WFCORE-4908.
> {code}
> [domain at localhost:9990 /] /host=master/server-config=server-one/jvm=default:write-attribute(name=jvm-options[...
> {code}



--
This message was sent by Atlassian Jira
(v7.13.8#713008)