[jboss-jira] [JBoss JIRA] (WFLY-13259) Memory leak in Hibernate pending-puts cache when L2 cache is enabled

[Radim Vansa (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010781#comment-14010781 ] 

Radim Vansa commented on WFLY-13259:
------------------------------------

[~smarlow] There have been significant changes for 5.3 that let 2LC hook into transaction; {{RegionFactory.createTransactionContext()}} creates {{CacheTransactionSynchronization}} which has {{transactionCompleting()}} and {{transactionCompleted}} methods that are invoked before/after DB commit (2LC hooks as a Synchronization, not a XA resource as JPA does not guarantee any order in which XA resources are called and we need to do stuff strictly after DB commit).
The {{PutFromLoadValidator}} gets the session just as an {{Object}} as it is compatible with both 5.1 and 5.3 and it needed only to compare the objects, not call any Session-specific methods. You'll have to somehow deal with it (override for 5.3?) so that you can call {{SharedSessionContractImplementor.getCacheTransactionSynchronization()}} and register the operations.

> Memory leak in Hibernate pending-puts cache when L2 cache is enabled
> --------------------------------------------------------------------
>
>                 Key: WFLY-13259
>                 URL: https://issues.redhat.com/browse/WFLY-13259
>             Project: WildFly
>          Issue Type: Bug
>          Components: JPA / Hibernate
>    Affects Versions: 18.0.1.Final, 19.0.0.Final
>            Reporter: Sorin Potra
>            Assignee: Scott Marlow
>            Priority: Critical
>         Attachments: PathToGCRoots_strong_refs.PNG, afterOOM.hprof.zip, beforeOOM.hprof.zip, pending-puts-leak.PNG, simple-hibernate-war-client.zip, simple-hibernate-war-client.zip.2020-03-25, simple-hibernate-war.war, simple-hibernate-war.war.2020-03-25, simple-hibernate-war.zip, simple-hibernate-war.zip.2020-03-25
>
>
> Under certain conditions, described below, WildFly / Hibernate can leak memory into the pending-puts cache eventually causing an OutOfMemoryError. Attached you can find a web application and a standalone client that can be used to reproduce the problem. The web app defines two entities: a Parent and a Child. There is a bidirectional one-to-many relationship between the Parent and the Child. JPA L2 cache is enabled (Infinispan is the cache provider).
> Repeatedly executing a transaction that creates a new Child and adds it to the list of children in the Parent will cause the memory usage to increase steadily until OOM is encountered. If the execution of these transactions is stopped before reaching OOM, the memory will be reclaimed after a few minutes of inactivity.
> Attached you can find the following:
> - simple-hibernate-war.war - the web app that can be deployed in WildFly to reproduce the issue.
> - simple-hibernate-war.zip - the source code for the above web app. The servlet that is invoked by the client to create and persist a new Child is com.microfocus.sa.web.AddChildServlet
> - simple-hibernate-war-client.zip - the standalone client that can be used to invoke the AddChildServlet. After unzipping the archive, the client can be run with the following command from the client folder:
>   
>   java -cp bin com.microfocus.sa.client.AddChildClient
>   
> If you need to run the client multiple times, you have to restart WildFly in between the runs, to start from a fresh state (the web app uses the h2 in memory databasewhich is reset at each restart).
> - pending-puts-leak.PNG - a screeshot from Memory Analyzer showing a leaked SessionImpl instance



--
This message was sent by Atlassian Jira
(v7.13.8#713008)