[jboss-jira] [JBoss JIRA] (WFLY-13432) Provide capability for Undertow HTTP Upgrade registry

[Richard Achmatowicz (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085257#comment-14085257 ] 

Richard Achmatowicz edited comment on WFLY-13432 at 5/8/20 4:46 PM:
--------------------------------------------------------------------

The HTTP Upgrade feature of Undertow depends on other subsystems having access to a Value service defined in the Undertow HttpListenerResource. The ServiceName is JBOSS."http-upgrade-registry" and the value returned is ChannelUpgradeHandler. The ChannelUpgradeHandler is used by other subsystems to plug-in specific pieces to allow an HTTP Upgrade to a specific protocol to take place. Every HTTP request passes through the ChannelUpgradeHandler and so every request has the possibility to upgrade, depending on the content of the HTTP message headers.

This is used by other subsystems (remoting, host-controller, and server in Wildfly core, and messaging-activemq in Wildfly) and currently does no make use of capabilities. 

I added a capability HTTP_UPGRADE_REGISTRY_CAPABILIY in HttpListenerResourceDefinition and used it to generate the ServiceName for the Value service. Because other subsystems still rely on the old ServiceName, I added that ServiceName as an alias when building the service so that the other subsystems would not be affected. Thanks to Paul F. for helping out with that!

   


was (Author: rachmato):
The HTTP Upgrade feature of Undertow depends on other subsystems having access to a Value service defined in the Undertow HttpListenerResource. The ServiceName is JBOSS."http-upgrade-registry" and the value returned is ChannelUpgradeHandler. The ChannelUpgradeHandler is used by other subsystems to plug-in specific pieces to allow an HTTP Upgrade to a specific protocol to take place. Every HTTP request passes through the ChannelUpgradeHandler and so every request has the possibility to upgrade.  

This is used by other subsystems (remoting, host-controller, and server in Wildfly core, and messaging-activemq in Wildfly) and currently does no make use of capabilities. 

I added a capability HTTP_UPGRADE_REGISTRY_CAPABILIY in HttpListenerResourceDefinition and used it to generate the ServiceName for the Value service. Because other subsystems still rely on the old ServiceName, I added that ServiceName as an alias when building the service so that the other subsystems would not be affected. Thanks to Paul F. for helping out with that!

   

> Provide capability for Undertow HTTP Upgrade registry
> -----------------------------------------------------
>
>                 Key: WFLY-13432
>                 URL: https://issues.redhat.com/browse/WFLY-13432
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 20.0.0.Beta1
>            Reporter: Richard Achmatowicz
>            Assignee: Richard Achmatowicz
>            Priority: Major
>
> The HTTP Upgrade feature of Undertow depends on subsystems such as Messaging and EJB having access to a registry of upgrade protocols (ChannelUpgradeHandler) provided by Undertow. This needs to be updated to use capabilities.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)