[jboss-jira] [JBoss JIRA] (DROOLS-5324) Refactor "if" driven compilation for dmn/pmml

[Mario Fusco (Jira)]

    [ https://issues.redhat.com/browse/DROOLS-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093669#comment-14093669 ] 

Mario Fusco commented on DROOLS-5324:
-------------------------------------

Reference https://github.com/kiegroup/drools/blob/master/drools-model/drools-model-compiler/src/main/java/org/drools/modelcompiler/CanonicalKieModule.java#L198

> Refactor "if" driven compilation for dmn/pmml
> ---------------------------------------------
>
>                 Key: DROOLS-5324
>                 URL: https://issues.redhat.com/browse/DROOLS-5324
>             Project: Drools
>          Issue Type: Task
>            Reporter: Gabriele Cardosi
>            Assignee: Mario Fusco
>            Priority: Major
>
> Inside
> {code:java}
>  CanonicalKieModule.createKieBase( KieBaseModelImpl, KieProject, ResultsImpl, KieBaseConfiguration)
> {code}
> there is a call to
> {code:java}
>  CanonicalKieModule.hasNonModelResources( KieBaseModelImpl, KieProject )
> {code}
> This method returns `true` if there are some dmn and/or pmml files in the project.
> If such boolean is `true` a new KnowledgePackagesBuildResult is created.
> The main issues with this approach are:
> 1) managing of dmn/pmml resources is completely hidden inside this boolean method and hard to find in debug
> 2) it is possible that the new KnowledgePackagesBuildResult build will fire a compilation also of "drl" or other resources that are "compiled" anyway even without this flag



--
This message was sent by Atlassian Jira
(v7.13.8#713008)