[jboss-jira] [JBoss JIRA] (DROOLS-5360) Avoid direct invocation of PMMLModelExecutor.evaluate

Gabriele Cardosi (Jira) issues at jboss.org
Wed May 27 09:26:18 EDT 2020


     [ https://issues.redhat.com/browse/DROOLS-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriele Cardosi updated DROOLS-5360:
-------------------------------------
    Description: 
-Change PMMLModelExecutor public API so that user should not retrieve the KiePMMLModel to invoke the "evaluate" method-


{code:java}
-PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)-
{code}  
 ->
{code:java}
-PMML4Result evaluate(final KieBase knowledgeBase, String modelName, PMMLContext context);-
{code}

-Create AbstractPMMLModelExecutor that implement the above interface and declare an abstract method -
{code:java}
-PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)-
{code}  

-AbstractPMMLModelExecutor should then use KnoweledgeBaseUtils to retrieve the KiePMMLModel and invoke/delegate to actual implementations-
-
Actual implementations should then extend AbstractPMMLModelExecutor--



  was:
-Change PMMLModelExecutor public API so that user should not retrieve the KiePMMLModel to invoke the "evaluate" method-


{code:java}
PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)
{code}  
 ->
{code:java}
PMML4Result evaluate(final KieBase knowledgeBase, String modelName, PMMLContext context);
{code}

Create AbstractPMMLModelExecutor that implement the above interface and declare an abstract method 
{code:java}
PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)
{code}  

AbstractPMMLModelExecutor should then use KnoweledgeBaseUtils to retrieve the KiePMMLModel and invoke/delegate to actual implementations

Actual implementations should then extend AbstractPMMLModelExecutor-





> Avoid direct invocation of PMMLModelExecutor.evaluate
> -----------------------------------------------------
>
>                 Key: DROOLS-5360
>                 URL: https://issues.redhat.com/browse/DROOLS-5360
>             Project: Drools
>          Issue Type: Task
>            Reporter: Gabriele Cardosi
>            Assignee: Gabriele Cardosi
>            Priority: Major
>              Labels: TrustyAI
>
> -Change PMMLModelExecutor public API so that user should not retrieve the KiePMMLModel to invoke the "evaluate" method-
> {code:java}
> -PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)-
> {code}  
>  ->
> {code:java}
> -PMML4Result evaluate(final KieBase knowledgeBase, String modelName, PMMLContext context);-
> {code}
> -Create AbstractPMMLModelExecutor that implement the above interface and declare an abstract method -
> {code:java}
> -PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)-
> {code}  
> -AbstractPMMLModelExecutor should then use KnoweledgeBaseUtils to retrieve the KiePMMLModel and invoke/delegate to actual implementations-
> -
> Actual implementations should then extend AbstractPMMLModelExecutor--



--
This message was sent by Atlassian Jira
(v7.13.8#713008)


More information about the jboss-jira mailing list