[jboss-svn-commits] JBL Code SVN: r5904 - labs/jbossrules/trunk/drools-ide/src/main/java/org/drools/ide/menu

[jboss-svn-commits at lists.jboss.org]

Author: KrisVerlaenen
Date: 2006-08-15 18:04:20 -0400 (Tue, 15 Aug 2006)
New Revision: 5904

Modified:
   labs/jbossrules/trunk/drools-ide/src/main/java/org/drools/ide/menu/RuleHelperActionDelegate.java
Log:
JBRULES-426: Memory leak in RuleHelperActionDelegate
 - existing menu is disposed off when setting a new one

Modified: labs/jbossrules/trunk/drools-ide/src/main/java/org/drools/ide/menu/RuleHelperActionDelegate.java
===================================================================
--- labs/jbossrules/trunk/drools-ide/src/main/java/org/drools/ide/menu/RuleHelperActionDelegate.java	2006-08-15 21:10:20 UTC (rev 5903)
+++ labs/jbossrules/trunk/drools-ide/src/main/java/org/drools/ide/menu/RuleHelperActionDelegate.java	2006-08-15 22:04:20 UTC (rev 5904)
@@ -36,11 +36,12 @@
     IWorkbenchWindowPulldownDelegate {
 
     private IWorkbench workbench;
+    private Menu menu;
 
     /** Return a menu which launches the various wizards */
     public Menu getMenu(Control parent) {
 
-        Menu menu = new Menu( parent );
+        setMenu( new Menu( parent ) );
         
         final Shell shell = parent.getShell();
         addProjectWizard( menu,
@@ -57,6 +58,13 @@
         
         return menu;
     }
+    
+    private void setMenu(Menu menu) {
+        if (this.menu != null) {
+            this.menu.dispose();
+        }
+        this.menu = menu;
+    }
 
     private void addDTWizard(Menu menu,
                              final Shell shell) {