[jboss-svn-commits] JBL Code SVN: r6005 - in labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository: . test

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2006-08-29 11:49:44 -0400 (Tue, 29 Aug 2006)
New Revision: 6005

Modified:
   labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/FunctionItem.java
   labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/ItemVersionIterator.java
   labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RuleItem.java
   labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulePackageItem.java
   labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulesRepository.java
   labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/test/RulePackageItemTestCase.java
Log:
more working

Modified: labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/FunctionItem.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/FunctionItem.java	2006-08-29 15:17:43 UTC (rev 6004)
+++ labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/FunctionItem.java	2006-08-29 15:49:44 UTC (rev 6005)
@@ -304,7 +304,6 @@
      * @return a list of TagItem objects for each tag on the node. If there are no tags, an empty list. 
      * @throws RulesRepositoryException
      */
-    @SuppressWarnings("unchecked")
     public List getTags() throws RulesRepositoryException {
         try {                            
             Node functionNode;

Modified: labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/ItemVersionIterator.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/ItemVersionIterator.java	2006-08-29 15:17:43 UTC (rev 6004)
+++ labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/ItemVersionIterator.java	2006-08-29 15:49:44 UTC (rev 6005)
@@ -53,7 +53,7 @@
         else {
             //shouldn't reach this block
             log.error("Reached unexpected path of execution because iterationType is set to: " + this.iterationType);
-            return false;
+            return null;
         }
         
         if(this.currentVersionableItem == null) {

Modified: labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RuleItem.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RuleItem.java	2006-08-29 15:17:43 UTC (rev 6004)
+++ labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RuleItem.java	2006-08-29 15:49:44 UTC (rev 6005)
@@ -537,7 +537,6 @@
      * @return a list of TagItem objects for each tag on the rule. If there are no tags, an empty list. 
      * @throws RulesRepositoryException
      */
-    @SuppressWarnings("unchecked")
     public List getTags() throws RulesRepositoryException {
         try {                            
             Node ruleNode;

Modified: labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulePackageItem.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulePackageItem.java	2006-08-29 15:17:43 UTC (rev 6004)
+++ labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulePackageItem.java	2006-08-29 15:49:44 UTC (rev 6005)
@@ -329,8 +329,7 @@
      * 
      * @return the List object holding the FunctionItem objects in this rule package
      * @throws RulesRepositoryException 
-     */
-    @SuppressWarnings("unchecked")
+     */   
     public List getFunctions() throws RulesRepositoryException {
         try {                       
             Value[] valueArray = this.node.getProperty(FUNCTION_REFERENCE_PROPERTY_NAME).getValues();
@@ -358,7 +357,6 @@
      * @return the List object holding the RuleItem objects in this rule package
      * @throws RulesRepositoryException 
      */
-    @SuppressWarnings("unchecked")
     public List getRules() throws RulesRepositoryException {
         try {                       
             Value[] valueArray = this.node.getProperty(RULE_REFERENCE_PROPERTY_NAME).getValues();

Modified: labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulesRepository.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulesRepository.java	2006-08-29 15:17:43 UTC (rev 6004)
+++ labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/RulesRepository.java	2006-08-29 15:49:44 UTC (rev 6005)
@@ -944,7 +944,6 @@
      * Only the latest versions of each FunctionItem will be returned (you will have 
      * to delve into the functions' deepest darkest history yourself... mahahahaha).
      */
-    @SuppressWarnings("unchecked")
     public List findFunctionsByTag(String categoryTag) throws RulesRepositoryException {        
         CategoryItem item = this.getOrCreateCategory( categoryTag );
         List results = new ArrayList();
@@ -971,7 +970,6 @@
      * Only the latest versions of each RuleItem will be returned (you will have 
      * to delve into the rules deepest darkest history yourself... mahahahaha).
      */
-    @SuppressWarnings("unchecked")
     public List findRulesByTag(String categoryTag) throws RulesRepositoryException {
         
         CategoryItem item = this.getOrCreateCategory( categoryTag );
@@ -1010,7 +1008,6 @@
      * This will provide a list of top level category strings. 
      * Use getCategory to get a specific category to drill down into it.
      */
-    @SuppressWarnings("unchecked")
     public List listCategoryNames() throws RulesRepositoryException {
         try {
             

Modified: labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/test/RulePackageItemTestCase.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/test/RulePackageItemTestCase.java	2006-08-29 15:17:43 UTC (rev 6004)
+++ labs/jbossrules/trunk/drools-repository/src/java/org/drools/repository/test/RulePackageItemTestCase.java	2006-08-29 15:49:44 UTC (rev 6005)
@@ -21,7 +21,7 @@
         this.rulesRepository.logout();
     }
 
-    public void testRulePackageItem() {
+    public void testRulePackageItem() throws Exception {
         try {
             //calls constructor
             RulePackageItem rulePackageItem1 = this.rulesRepository.createRulePackage("testRulePackage");
@@ -252,7 +252,6 @@
     }
     
     public void testGetRules() {
-        try {
             RulePackageItem rulePackageItem1 = this.rulesRepository.createRulePackage("testRulePackage");
                         
             RuleItem ruleItem1 = this.rulesRepository.addRule("test rule", "test lhs content", "test rhs content");
@@ -270,11 +269,7 @@
             rules = rulePackageItem1.getRules();
             assertNotNull(rules);
             assertEquals(2, rules.size());            
-        }
-        catch(Exception e) {
-            e.printStackTrace();
-            fail("Caught unexpected exception: " + e);
-        }
+
     }
 
     public void testToString() {