[jboss-svn-commits] JBL Code SVN: r6055 - labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines

[jboss-svn-commits at lists.jboss.org]

Author: wrzep
Date: 2006-08-31 18:04:36 -0400 (Thu, 31 Aug 2006)
New Revision: 6055

Modified:
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesEvaluator.java
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesTotalPlugin.java
Log:
JBLAB-751
Binary search fix.

Pawel


Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesEvaluator.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesEvaluator.java	2006-08-31 21:55:05 UTC (rev 6054)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesEvaluator.java	2006-08-31 22:04:36 UTC (rev 6055)
@@ -114,18 +114,18 @@
 		}
 		long mid;
 		
-	    while (left <= right) {
+	    while (left < right) {
 	    	
-	    	System.out.println("l: " + left + " r: " + right);
-	    	
-	    	mid = Math.round(Math.floor((left+right)/2));
+	    		mid = Math.round(Math.floor((left+right)/2));
 	    
-	    	if (isValidRevision(repository, mid)) {
-	    		right = mid - 1;
-	    	} else {
-	    		left = mid;
-	    	}
+	    		if (isValidRevision(repository, mid)) {
+	    			right = mid;
+	    		} else {
+	    			left = mid + 1;
+	    		}
 	    }
+	    
+	    System.out.println("The oldest revision: " + left);
 		
 	    return SVNRevision.create(left);		
 	}

Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesTotalPlugin.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesTotalPlugin.java	2006-08-31 21:55:05 UTC (rev 6054)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesTotalPlugin.java	2006-08-31 22:04:36 UTC (rev 6055)
@@ -35,11 +35,10 @@
 		if ((userName != null) && (password != null)) {
 			return CodeLinesEvaluator.getCodeLinesNumber(url, userName, password);
 		}
-	
+		
 		//long ret = CodeLinesEvaluator.getCodeLinesNumber(url);
-	
+		
 		long ret0 = CodeLinesEvaluator.getCodeLinesNumberFast(url);
-		System.out.println("CodeLinesTotal (URL: " + url + ")" + ": " + ret0);
 		
 		return ret0;
 	}