[jboss-svn-commits] JBL Code SVN: r7367 - in labs/jbossrules/trunk/drools-jbrms/src: main/java/org/drools/brms/server test/java/org/drools/brms/server

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2006-11-03 11:12:37 -0500 (Fri, 03 Nov 2006)
New Revision: 7367

Modified:
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/JBRMSServiceServlet.java
   labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java
Log:
more tests for changing state and reloading assets

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/JBRMSServiceServlet.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/JBRMSServiceServlet.java	2006-11-03 16:11:57 UTC (rev 7366)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/JBRMSServiceServlet.java	2006-11-03 16:12:37 UTC (rev 7367)
@@ -204,7 +204,9 @@
         asset.dateEffective = formatDate( item.getDateEffective() );
         asset.dateExpired = formatDate( item.getDateExpired() );
         
-        
+        //TODO: this could be refactored to there are different loadXXX methods, or 
+        //use polymorphism or something, in any case avoiding this dirty if statement...
+        //as we know at the "client" what we should be loaded from the format string.
         if (item.getFormat().equals( "DSL" )) {
             //ok here is where we do DSLs...
             throw new SerializableException("Can't load DSL rules just yet.");

Modified: labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java	2006-11-03 16:11:57 UTC (rev 7366)
+++ labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java	2006-11-03 16:12:37 UTC (rev 7367)
@@ -128,7 +128,6 @@
       assertNotNull(fmt);
       
       assertTrue(fmt.length() > 8);
-      System.out.println(fmt);
   }
   
   public void testLoadRuleAsset() throws Exception {
@@ -145,7 +144,7 @@
       TableDataRow row = res.data[0];
       String uuid = row.id;
       
-      System.out.println("UUID: " + uuid);
+
       
       RuleAsset asset = impl.loadRuleAsset( uuid );
       assertNotNull(asset);
@@ -158,7 +157,15 @@
       assertEquals("testLoadRuleAsset", asset.metaData.name);
       assertEquals("testLoadRuleAsset", asset.metaData.title);
       assertEquals("testLoadRuleAsset", asset.metaData.packageName);
+   
+      RuleItem rule = impl.repo.loadRulePackage( "testLoadRuleAsset" ).loadRule( "testLoadRuleAsset" );
+      rule.updateState( "whee" );
+      rule.checkin( "changed state" );
+      asset = impl.loadRuleAsset( uuid );
       
+      assertEquals("whee", asset.metaData.state);
+      
+      
   }