[jboss-svn-commits] JBL Code SVN: r7499 - in labs/jbossesb/trunk/product/core/rosetta/src/org/jboss: internal/soa/esb/couriers soa/esb/couriers

[jboss-svn-commits at lists.jboss.org]

Author: kurt.stam at jboss.com
Date: 2006-11-09 11:00:48 -0500 (Thu, 09 Nov 2006)
New Revision: 7499

Modified:
   labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/internal/soa/esb/couriers/JmsCourier.java
   labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/soa/esb/couriers/Courier.java
Log:
Cleaning up exception handling

Modified: labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/internal/soa/esb/couriers/JmsCourier.java
===================================================================
--- labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/internal/soa/esb/couriers/JmsCourier.java	2006-11-09 15:48:14 UTC (rev 7498)
+++ labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/internal/soa/esb/couriers/JmsCourier.java	2006-11-09 16:00:48 UTC (rev 7499)
@@ -218,11 +218,11 @@
 		// TODO Auto-generated method stub
 		return null;
 	}
-	public void stopDurableDelivery() throws CourierException {
+	public void stopDurableDelivery()  {
 		// TODO Auto-generated method stub
 		
 	}
-	public void stopDurablePickup() throws CourierException {
+	public void stopDurablePickup()  {
 		// TODO Auto-generated method stub
 		
 	}

Modified: labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/soa/esb/couriers/Courier.java
===================================================================
--- labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/soa/esb/couriers/Courier.java	2006-11-09 15:48:14 UTC (rev 7498)
+++ labs/jbossesb/trunk/product/core/rosetta/src/org/jboss/soa/esb/couriers/Courier.java	2006-11-09 16:00:48 UTC (rev 7499)
@@ -24,6 +24,7 @@
 
 import org.jboss.soa.esb.message.Message;
 /**
+ * Courier interface. Deals relatively low level Message transport options.
  * 
  * @author esteban
  * @author kstam at redhat.com
@@ -49,12 +50,12 @@
 	 */
 	public boolean deliverNext(Message message) throws CourierException;
 	/**
-	 * Waits for a certain amount of time (waitTime) at an address to pick up a message.
+	 * Waits for a certain amount of time (waitTime) at an address (EPR) to pick up a message.
 	 * 
 	 * @param message Message - the message to deliver.
 	 * @param waitTime        - Timeout for before giving up in millis.
 	 * @return                - the (reply)Message.
-	 * @throws CourierException the courier fails (i.e. gets a flat tire).
+	 * @throws CourierException if the courier fails (i.e. gets a flat tire).
 	 * @throws CourierTimeoutException if the pickup timed out (nobody home).
 	 */
 	public Message deliverAndWaitForPickup(Message message,long waitTime) 
@@ -75,23 +76,20 @@
     /**
      * Creates a durable pickup contract if one does not exist and tries to obtain the next message.
      * 
-     * @param waitTime         - Pickup timeout for before giving up on this pickup. Time in millis.
-     * @return                - the message that was picked up.
-     * @throws CourierException
+     * @param waitTime         - Pickup timeout before giving up on this pickup. Time in millis.
+     * @return                 - the message that was picked up.
+     * @throws CourierException the courier fails (i.e. gets a flat tire).
+	 * @throws CourierTimeoutException if the pickup timed out (nobody home).
      */
-	public Message pickupNext(long waitTime) throws CourierException;
+	public Message pickupNext(long waitTime) throws CourierException, CourierTimeoutException;
 	/**
 	 * When you were engaged in a durable pickup, you need to notify the Courier you want to break
 	 * that contract. The courier will no longer stand by to go out for pickup.
-	 * 
-	 * @throws CourierException
 	 */
-	public void stopDurablePickup() throws CourierException;
+	public void stopDurablePickup();
 	/**
 	 * When you were engaged in a durable delivary, you need to notify the Courier you want to break
-	 * that contract. The courier will no longer stand by to deliver.
-	 * 
-	 * @throws CourierException
+	 * that contract. The courier will no longer stand by for delivery.
 	 */
-	public void stopDurableDelivery() throws CourierException;
+	public void stopDurableDelivery();
 }