[jboss-svn-commits] JBL Code SVN: r7538 - in labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins: cc codelines productization

[jboss-svn-commits at lists.jboss.org]

Author: wrzep
Date: 2006-11-10 18:00:51 -0500 (Fri, 10 Nov 2006)
New Revision: 7538

Modified:
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/cc/CcBuildsPlugin.java
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/codelines/CodeLinesPlugin.java
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/productization/PackagedForDownloadPlugin.java
Log:
http://jira.jboss.com/jira/browse/JBLAB-756
Removed caching in separate plugins as global cache is now implemented.
Pawel


Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/cc/CcBuildsPlugin.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/cc/CcBuildsPlugin.java	2006-11-10 22:46:52 UTC (rev 7537)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/cc/CcBuildsPlugin.java	2006-11-10 23:00:51 UTC (rev 7538)
@@ -27,9 +27,7 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.net.URL;
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -49,21 +47,13 @@
 	
 	protected Logger log = Logger.getLogger(CcBuildsPlugin.class);
 	
-	protected Map<String,Long> cachedValues = new HashMap<String,Long>();
-	
 	@Override
 	public long getPluginValue(String projectId) {
 		
-		if (cachedValues.containsKey(projectId)) {
-			
-			return cachedValues.get(projectId);
-		}
-		
 		List<String> URLs = ProjectTools.getCcURLs(projectId);
 		
 		if (URLs == null) {
 			
-			cachedValues.put(projectId, (long) 0);
 			return 0;
 		}
 		
@@ -74,8 +64,6 @@
 			v += get(url);
 		}
 		
-		cachedValues.put(projectId, v);
-		
 		return v;
 	}
 

Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/codelines/CodeLinesPlugin.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/codelines/CodeLinesPlugin.java	2006-11-10 22:46:52 UTC (rev 7537)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/codelines/CodeLinesPlugin.java	2006-11-10 23:00:51 UTC (rev 7538)
@@ -23,11 +23,7 @@
 package org.jboss.forge.status.service.plugins.codelines;
 
 import java.util.List;
-import java.util.Map;
-import java.util.HashMap;
 
-
-import org.jboss.forge.common.projects.project.RepoType;
 import org.jboss.forge.common.projects.project.Repository;
 import org.jboss.forge.status.common.tools.ProjectTools;
 import org.jboss.forge.status.service.plugins.Plugin;
@@ -51,41 +47,31 @@
 	 */
 	protected abstract long getPluginValue(String url, String userName, String password); 
 	
-	/** Binds project ids with their values */
-	private Map<String,Long> cachedValues;
-	
 	protected static Logger log = Logger.getLogger(CodeLinesPlugin.class);
 	
 	public CodeLinesPlugin() {
 		super();
-		cachedValues = new HashMap<String,Long>();
 	}
 	
 	@Override
 	public long getPluginValue(String projectId) {
-		
-		if (!cachedValues.containsKey(projectId)) {
 			
-			long cl = 0;
+		long cl = 0;
 			
-			List<Repository> repoList = ProjectTools.getProjectCcRepositories(projectId);
+		List<Repository> repoList = ProjectTools.getProjectCcRepositories(projectId);
 			
-			if (repoList == null) {
+		if (repoList == null) {
 				
-				return 0;
-			}
+			return 0;
+		}
 			
-			for (Repository repository : repoList) {
-					
-				cl += analyze(repository.getValue());
-			}
-			
-			cachedValues.put(projectId, cl);
+		for (Repository repository : repoList) {
+				
+			cl += analyze(repository.getValue());
 		}
 		
-		Long value = cachedValues.get(projectId);
 	
-		return value == null ? 0 : value.longValue();
+		return cl;
 	}
 
 	private long analyze(String url) {

Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/productization/PackagedForDownloadPlugin.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/productization/PackagedForDownloadPlugin.java	2006-11-10 22:46:52 UTC (rev 7537)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/plugins/productization/PackagedForDownloadPlugin.java	2006-11-10 23:00:51 UTC (rev 7538)
@@ -22,7 +22,6 @@
 
 package org.jboss.forge.status.service.plugins.productization;
 
-import org.jboss.forge.common.projects.project.Downloads;
 import org.jboss.forge.status.common.tools.ProjectTools;
 import org.jboss.forge.status.service.plugins.Plugin;