[jboss-svn-commits] JBoss Portal SVN: r5701 - in trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration: api impl

[jboss-svn-commits at lists.jboss.org]

Author: julien at jboss.com
Date: 2006-11-21 05:17:29 -0500 (Tue, 21 Nov 2006)
New Revision: 5701

Modified:
   trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationManager.java
   trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationPersistenceManager.java
   trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/impl/RegistrationPersistenceManagerImpl.java
Log:
no need for update methods on the RegistrationPersistenceManager. The state modifying methods on the manager are sufficient.

Modified: trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationManager.java
===================================================================
--- trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationManager.java	2006-11-21 10:09:27 UTC (rev 5700)
+++ trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationManager.java	2006-11-21 10:17:29 UTC (rev 5701)
@@ -90,8 +90,6 @@
       String handle = policy.createRegistrationHandleFor(registration.getId());
       registration.setRegistrationHandle(handle);
 
-      registration = persistenceManager.save(registration);
-
       // associate the handle to the consumer for easy retrieval
       registrations.put(handle, new ConsumerRegistration(registration, consumer));
 
@@ -179,7 +177,6 @@
       if (group != null)
       {
          group.removeConsumer(consumer);
-         persistenceManager.save(group);
       }
 
       // cascade delete the registrations
@@ -239,7 +236,6 @@
 
       persistenceManager.removeRegistration(registration.getId());
       registrations.remove(registration.getRegistrationHandle());
-      persistenceManager.save(consumer);
    }
 
    public ConsumerGroup getConsumerGroup(String groupName) throws RegistrationException

Modified: trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationPersistenceManager.java
===================================================================
--- trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationPersistenceManager.java	2006-11-21 10:09:27 UTC (rev 5700)
+++ trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/api/RegistrationPersistenceManager.java	2006-11-21 10:17:29 UTC (rev 5701)
@@ -71,12 +71,6 @@
 
    Registration addRegistrationFor(String consumerIdentity, Map registrationProperties) throws RegistrationException;
 
-   ConsumerGroup save(ConsumerGroup group);
-
-   Registration save(Registration registration);
-
-   Consumer save(Consumer consumer);
-
    Collection getConsumerGroups();
 
    Registration getRegistration(String registrationId);

Modified: trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/impl/RegistrationPersistenceManagerImpl.java
===================================================================
--- trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/impl/RegistrationPersistenceManagerImpl.java	2006-11-21 10:09:27 UTC (rev 5700)
+++ trunk/wsrp/src/main/org/jboss/portal/wsrp/producer/registration/impl/RegistrationPersistenceManagerImpl.java	2006-11-21 10:17:29 UTC (rev 5701)
@@ -142,10 +142,6 @@
 
       registrations.put(registration.getId(), registration);
 
-      // is this needed?
-      save(registration);
-      save(consumer);
-
       return registration;
    }
 
@@ -170,10 +166,6 @@
 
       group.addConsumer(consumer);
 
-      // is this needed?
-      save(group);
-      save(consumer);
-
       return consumer;
    }
 
@@ -182,21 +174,6 @@
       return Collections.unmodifiableCollection(consumers.values());
    }
 
-   public ConsumerGroup save(ConsumerGroup group)
-   {
-      return group;  //todo: implement
-   }
-
-   public Registration save(Registration registration)
-   {
-      return registration;  //todo: implement
-   }
-
-   public Consumer save(Consumer consumer)
-   {
-      return consumer;  //todo: implement
-   }
-
    public Collection getConsumerGroups()
    {
       return Collections.unmodifiableCollection(groups.values());