[jboss-svn-commits] JBL Code SVN: r7939 - labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message

[jboss-svn-commits at lists.jboss.org]

Author: estebanschifman
Date: 2006-11-29 12:54:42 -0500 (Wed, 29 Nov 2006)
New Revision: 7939

Modified:
   labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/CbrJmsQueueListener.java
   labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java
Log:
Add appropriate logging to register/unregister exceptions

Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/CbrJmsQueueListener.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/CbrJmsQueueListener.java	2006-11-29 16:20:19 UTC (rev 7938)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/CbrJmsQueueListener.java	2006-11-29 17:54:42 UTC (rev 7939)
@@ -83,7 +83,13 @@
 	    		}
 	    		ruleLanguage =_config.getFirstChild(ListenerTagNames.CBR_TAG).getAttribute(ListenerTagNames.RULE_LANGUAGE_TAG);
 	    	}
-	    	_controller.register(_config,_epr);
+	    	try { _controller.register(_config,_epr); }
+	        catch (RegistryException re) 
+	        {
+	        	_logger.log("Unable to Register service",Priority.FATAL, re.getLocalizedMessage(), re);
+	        	return;
+	        }
+
 	    	while (_controller.continueLooping()) {
 	    		long lwait = _controller.millisToWait();
 	    		Message message = (lwait > 0 ) ? receiveEsbMessage(100) : null;
@@ -109,11 +115,14 @@
         			}
         		}
 	        }
-	    	_controller.unRegister(_eprCategoryName, _eprName, _epr);
+	    	try { _controller.unRegister(_eprCategoryName, _eprName, _epr); }
+	        catch (RegistryException re) 
+	        {
+	        	_logger.log("Unable to Un-register service",Priority.FATAL, re.getLocalizedMessage(), re);
+	        }
+
     	} catch (ListenerInitializationException lie) {
     		_logger.log(Priority.FATAL, lie.getLocalizedMessage(), lie);
-	    } catch (RegistryException re) {
-	    	_logger.log(Priority.FATAL, re.getLocalizedMessage(), re);
     	} catch (MessageRouterException mre) {
 			_logger.log(Priority.FATAL, mre.getLocalizedMessage(), mre);
 		} finally {

Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java	2006-11-29 16:20:19 UTC (rev 7938)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java	2006-11-29 17:54:42 UTC (rev 7939)
@@ -82,33 +82,36 @@
      */
     public void run()
     {
-    	try {
-	    	_controller.register(_config,_epr);
-	
-	    	while (_controller.continueLooping())
-	        {
-	    		long lwait = _controller.millisToWait();
-	    		org.jboss.soa.esb.message.Message message = (lwait > 0 ) ? receiveEsbMessage(100) : null;
-	        	if (null!=message)
-	        	{	
-	        		ActionProcessingPipeline chain = null;
-	
-	        		try	{ chain = new ActionProcessingPipeline(message,_config); }
-	        		catch (IllegalArgumentException e)	
-	        			{	_logger.error(e); 	continue; }
-	        		catch (ConfigurationException e)
-	    				{	_logger.error(e); 	continue; }
-	
+    	 try { _controller.register(_config,_epr); }
+    	 catch (RegistryException re) 
+    	 {
+     		_logger.fatal("Could not register service " + re.getLocalizedMessage(),re);
+    	 }
+
+    	while (_controller.continueLooping())
+        {
+    		long lwait = _controller.millisToWait();
+    		org.jboss.soa.esb.message.Message message = (lwait > 0 ) ? receiveEsbMessage(100) : null;
+        	if (null!=message)
+        	{	
+        		ActionProcessingPipeline chain = null;
+
+        		try	{ chain = new ActionProcessingPipeline(message,_config); }
+        		catch (IllegalArgumentException e)	
+        			{	_logger.error(e); 	continue; }
+        		catch (ConfigurationException e)
+    				{	_logger.error(e); 	continue; }
+
 //	        		this.pipelineExecutorPool.submit(chain);
-	        		new Thread(chain).start();
-	        	}
-	        }
-	    	_controller.unRegister(_eprCategoryName, _eprName, _epr);
-    	} catch (RegistryException re) {
-    		_logger.fatal("Could not register myself. " + re.getLocalizedMessage(),re);
-    	} finally {
-    		cleanup();
-    	}
+        		new Thread(chain).start();
+        	}
+        }
+    	try { _controller.unRegister(_eprCategoryName, _eprName, _epr); }
+	   	catch (RegistryException re) 
+	   	{
+	   		_logger.fatal("Could not un register service " + re.getLocalizedMessage(),re);
+	   	}
+    	cleanup();
     } // _______________________________
     
     /**