[jboss-svn-commits] JBL Code SVN: r7989 - in labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners: gateway message
jboss-svn-commits at lists.jboss.org
jboss-svn-commits at lists.jboss.org
Thu Nov 30 14:06:02 EST 2006
Author: estebanschifman
Date: 2006-11-30 14:05:56 -0500 (Thu, 30 Nov 2006)
New Revision: 7989
Modified:
labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/FileGatewayListener.java
labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/GatewayListenerController.java
labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/JmsGatewayListener.java
labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java
labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java
Log:
Add more debug and warning diagnostics to listeners and listener-controllers
Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/FileGatewayListener.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/FileGatewayListener.java 2006-11-30 17:17:46 UTC (rev 7988)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/FileGatewayListener.java 2006-11-30 19:05:56 UTC (rev 7989)
@@ -65,6 +65,8 @@
public void run()
{
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" started on thread "+Thread.currentThread().getName());
if (null!=_serviceName)
try { _controller.register(_config,_myEpr); }
catch (RegistryException e1)
@@ -172,6 +174,8 @@
if (null!=_serviceName)
try { _controller.unRegister(_serviceCategory, _serviceName,_myEpr); }
catch (RegistryException e1){ _logger.warn("unable to unRegister service",e1); }
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" finished on thread "+Thread.currentThread().getName());
} // ________________________________
@@ -197,6 +201,11 @@
try { _sleepBetweenPolls = 1000 * Long.parseLong(sAux); }
catch (NumberFormatException e)
{ _logger.warn("Invalid poll latency - keeping default of "+(_sleepBetweenPolls/1000)); }
+ else
+ {
+ _logger.warn("No value specified for: "+ListenerTagNames.POLL_LATENCY_SECS_TAG
+ +" - Using default of "+(_sleepBetweenPolls/1000));
+ }
resolveComposerClass();
@@ -217,30 +226,49 @@
throw new Exception ("Invalid "+ListenerTagNames.FILE_WORK_SFX_TAG+" attribute");
if (_inputSuffix.equals(_workingSuffix))
throw new Exception("Work suffix must differ from input suffix <"+_workingSuffix+">");
+ if (null==_config.getAttribute(ListenerTagNames.FILE_WORK_SFX_TAG))
+ _logger.warn("No value specified for: "+ListenerTagNames.FILE_WORK_SFX_TAG
+ +" - Using default of '"+_workingSuffix+"'");
// ERROR directory and suffix (defaults to input dir and ".esbError" suffix)
String sErrDir = _controller.obtainAtt(_config,ListenerTagNames.FILE_ERROR_DIR_TAG,sInpDir);
_errorDirectory = fileFromString(sErrDir);
+ if (null==_config.getAttribute(ListenerTagNames.FILE_ERROR_DIR_TAG))
+ _logger.warn("No value specified for: "+ListenerTagNames.FILE_ERROR_DIR_TAG
+ +" - Using input directory ("+sErrDir+")");
seeIfOkToWorkOnDir(_errorDirectory);
_errorSuffix = _controller.obtainAtt(_config,ListenerTagNames.FILE_ERROR_SFX_TAG,".esbError").trim();
if (_errorSuffix.length()<1)
throw new Exception ("Invalid "+ListenerTagNames.FILE_ERROR_SFX_TAG+" attribute");
+ if (null==_config.getAttribute(ListenerTagNames.FILE_ERROR_SFX_TAG))
+ _logger.warn("No value specified for: "+ListenerTagNames.FILE_ERROR_SFX_TAG
+ +" - Using default of '"+_errorSuffix+"'");
if (_errorDirectory.equals(_inputDirectory) && _inputSuffix.equals(_errorSuffix))
throw new Exception("Error suffix must differ from input suffix <"+_errorSuffix+">");
// Do users wish to delete files that were processed OK ?
String sPostDel = _controller.obtainAtt(_config,ListenerTagNames.FILE_POST_DEL_TAG,"false").trim();
+ if (null==_config.getAttribute(ListenerTagNames.FILE_POST_DEL_TAG))
+ _logger.warn("No value specified for: "+ListenerTagNames.FILE_POST_DEL_TAG
+ +" - Using default of 'false'");
_deleteAfterOK = Boolean.parseBoolean(sPostDel);
if (_deleteAfterOK)
return;
// POST (done) directory and suffix (defaults to input dir and ".esbDone" suffix)
String sPostDir = _controller.obtainAtt(_config,ListenerTagNames.FILE_POST_DIR_TAG,sInpDir);
+ if (null==_config.getAttribute(ListenerTagNames.FILE_POST_DIR_TAG))
+ _logger.warn("No value specified for: "+ListenerTagNames.FILE_POST_DIR_TAG
+ +" - Using default of '"+sPostDir+"'");
_postProcessDirectory = fileFromString(sPostDir);
seeIfOkToWorkOnDir(_postProcessDirectory);
_postProcessSuffix = _controller.obtainAtt(_config,ListenerTagNames.FILE_POST_SFX_TAG,".esbDone").trim();
+ if (null==_config.getAttribute(ListenerTagNames.FILE_POST_SFX_TAG))
+ _logger.warn("No value specified for: "+ListenerTagNames.FILE_POST_SFX_TAG
+ +" - Using default of '"+_postProcessSuffix+"'");
+
if (_postProcessDirectory.equals(_inputDirectory))
{ if (_postProcessSuffix.length()<1)
throw new Exception ("Invalid "+ListenerTagNames.FILE_POST_SFX_TAG+" attribute");
@@ -270,6 +298,8 @@
_composerClass= PackageFileContents.class;
_composer = new PackageFileContents();
sProcessMethod = "process";
+ _logger.warn("No <"+ListenerTagNames.ACTION_ELEMENT_TAG+"> element found in cofiguration"
+ +" - Using default composer class : "+_composerName);
}
_processMethod = _composerClass.getMethod(sProcessMethod,new Class[] {Object.class});
Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/GatewayListenerController.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/GatewayListenerController.java 2006-11-30 17:17:46 UTC (rev 7988)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/GatewayListenerController.java 2006-11-30 19:05:56 UTC (rev 7989)
@@ -207,6 +207,13 @@
: (null == _commandQueue)
? Long.MAX_VALUE
: System.currentTimeMillis() + _defaultReloadMillis;
+ if (null==sRldSecs)
+ {
+ String sMsg = (null==_commandQueue)
+ ? " - Using default of "+sRldSecs
+ : " - Listener will run until stopped by command sent to queue";
+ _logger.warn("No value specified for: "+RELOAD_SECONDS_TAG + sMsg);
+ }
// if END_TIME_TAG not set try to run forever
// not a good practice if command queue is not set
@@ -214,7 +221,13 @@
String sEndT = p_oP.getAttribute(END_TIME_TAG);
_endTime = (null == sEndT) ? Long.MAX_VALUE : _dateFormat.parse(
sEndT).getTime();
-
+ if (null==sEndT)
+ {
+ String sMsg = (null==_commandQueue)
+ ? " - Will run forever (or until interrupted by user)"
+ : " - Listener will run until stopped by command sent to queue";
+ _logger.warn("No value specified for: "+END_TIME_TAG + sMsg);
+ }
} // ________________________________
/**
Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/JmsGatewayListener.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/JmsGatewayListener.java 2006-11-30 17:17:46 UTC (rev 7988)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/JmsGatewayListener.java 2006-11-30 19:05:56 UTC (rev 7989)
@@ -67,6 +67,8 @@
public void run()
{
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" started on thread "+Thread.currentThread().getName());
if (null!=_serviceName)
try { _controller.register(_config,_myEpr); }
catch (RegistryException e1)
@@ -148,6 +150,8 @@
if (null != _queueConnection)
try { _queueConnection.close(); }
catch (Exception e2) {/* Tried my best - Just continue */ }
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" finished on thread "+Thread.currentThread().getName());
} // ________________________________
/**
@@ -172,6 +176,8 @@
// No problem if selector is null - everything in queue will be returned
_messageSelector = _config.getAttribute(JMSEpr.MESSAGE_SELECTOR_TAG);
+ _logger.debug("No value specified for: "+JMSEpr.MESSAGE_SELECTOR_TAG
+ +" - All messages in queue will be received by this listener");
prepareMessageReceiver();
} // ________________________________
@@ -197,6 +203,8 @@
_composerClass= PackageJmsMessageContents.class;
_composer = new PackageJmsMessageContents();
sProcessMethod = "process";
+ _logger.warn("No <"+ListenerTagNames.ACTION_ELEMENT_TAG+"> element found in cofiguration"
+ +" - Using default composer class : "+_composerName);
}
_processMethod = _composerClass.getMethod(sProcessMethod,new Class[] {Object.class});
@@ -209,10 +217,19 @@
_queue = null;
String sJndiType = _controller.obtainAtt(_config, JMSEpr.JNDI_TYPE_TAG,"jboss");
+ if (null==_config.getAttribute(JMSEpr.JNDI_TYPE_TAG))
+ _logger.debug("No value specified for "+JMSEpr.JNDI_TYPE_TAG+" attribute"
+ +" - Using default of: '"+sJndiType+"'");
String sJndiURL = _controller.obtainAtt(_config, JMSEpr.JNDI_URL_TAG,"localhost");
+ if (null==_config.getAttribute(JMSEpr.JNDI_URL_TAG))
+ _logger.debug("No value specified for "+JMSEpr.JNDI_URL_TAG+" attribute"
+ +" - Using default of: '"+sJndiURL+"'");
Context oJndiCtx = AppServerContext.getServerContext(sJndiType,sJndiURL);
String sFactClass = _controller.obtainAtt(_config,JMSEpr.CONNECTION_FACTORY_TAG, "ConnectionFactory");
+ if (null==_config.getAttribute(JMSEpr.CONNECTION_FACTORY_TAG))
+ _logger.debug("No value specified for "+JMSEpr.CONNECTION_FACTORY_TAG+" attribute"
+ +" - Using default of: '"+sFactClass+"'");
_serviceName = _config.getAttribute(ListenerTagNames.SERVICE_NAME_TAG);
_myEpr = (null==_serviceName) ? null
: new JMSEpr(JMSEpr.QUEUE_TYPE,_queueName,sFactClass,sJndiType,sJndiURL,_messageSelector);
Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java 2006-11-30 17:17:46 UTC (rev 7988)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java 2006-11-30 19:05:56 UTC (rev 7989)
@@ -87,6 +87,8 @@
public void run()
{
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" started on thread "+Thread.currentThread().getName());
if (null!=_serviceName)
try { _controller.register(_config,_myEpr); }
catch (RegistryException e1)
@@ -199,6 +201,8 @@
if (null!=_dbConn)
_dbConn.release();
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" finished on thread "+Thread.currentThread().getName());
} // ________________________________
/**
@@ -223,7 +227,12 @@
try { _sleepBetweenPolls = 1000 * Long.parseLong(sAux); }
catch (NumberFormatException e)
{ _logger.warn("Invalid poll latency - keeping default of "+(_sleepBetweenPolls/1000)); }
-
+ else
+ {
+ _logger.warn("No value specified for: "+ListenerTagNames.POLL_LATENCY_SECS_TAG
+ +" - Using default of "+(_sleepBetweenPolls/1000));
+ }
+
resolveComposerClass();
_driver = _controller.obtainAtt(_config, JDBCEpr.DRIVER_TAG , null);
@@ -245,11 +254,18 @@
throw new ConfigurationException("A valid inProcessField attribute must be specified");
_where = _controller.obtainAtt(_config, ListenerTagNames.SQL_WHERE_CONDITION_TAG,"");
+ if (_where.trim().length()<1)
+ _logger.debug("No value specified for: "+ListenerTagNames.SQL_WHERE_CONDITION_TAG);
_orderBy = _controller.obtainAtt(_config, ListenerTagNames.SQL_ORDER_BY_TAG,"");
+ if (_orderBy.trim().length()<1)
+ _logger.debug("No value specified for: "+ListenerTagNames.SQL_ORDER_BY_TAG);
_inProcessVals = _controller.obtainAtt(_config, ListenerTagNames.SQL_IN_PROCESS_VALUES_TAG,DEFAULT_IN_PROCESS_STATES);
_deleteAfterOK = Boolean.parseBoolean
(_controller.obtainAtt(_config,ListenerTagNames.SQL_POST_DEL_TAG,"false"));
+ if (null==_config.getAttribute(ListenerTagNames.SQL_POST_DEL_TAG))
+ _logger.debug("No value specified for: "+ListenerTagNames.SQL_POST_DEL_TAG
+ +" - trigger row will not be deleted - 'in process field' will be used to show processing status" );
if (_inProcessVals.length()<4)
throw new Exception("Parameter <"+ListenerTagNames.SQL_IN_PROCESS_VALUES_TAG
@@ -315,6 +331,8 @@
_composerClass= PackageRowContents.class;
_composer = new PackageRowContents();
sProcessMethod = "process";
+ _logger.warn("No <"+ListenerTagNames.ACTION_ELEMENT_TAG+"> element found in cofiguration"
+ +" - Using default composer class : "+_composerName);
}
_processMethod = _composerClass.getMethod(sProcessMethod,new Class[] {Object.class});
Modified: labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java
===================================================================
--- labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java 2006-11-30 17:17:46 UTC (rev 7988)
+++ labs/jbossesb/trunk/product/core/listeners/src/org/jboss/soa/esb/listeners/message/JmsQueueListener.java 2006-11-30 19:05:56 UTC (rev 7989)
@@ -82,6 +82,8 @@
*/
public void run()
{
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" started on thread "+Thread.currentThread().getName());
try { _controller.register(_config,_epr); }
catch (RegistryException re)
{
@@ -113,6 +115,8 @@
//TODO The problem is still here... Look into it for GA
}
cleanup();
+ _logger.debug("run() method of "+this.getClass().getSimpleName()
+ +" finished on thread "+Thread.currentThread().getName());
} // _______________________________
/**
@@ -132,16 +136,27 @@
// No problem if selector is null - everything in queue will be returned
_sSelector = _config.getAttribute(JMSEpr.MESSAGE_SELECTOR_TAG);
+ _logger.debug("No value specified for: "+JMSEpr.MESSAGE_SELECTOR_TAG
+ +" - All messages in queue will be received by this listener");
_oQconn = null;
_oQsess = null;
_oQueue = null;
_jndiType = obtainAttribute (JMSEpr.JNDI_TYPE_TAG ,"jboss");
+ if (null==_config.getAttribute(JMSEpr.JNDI_TYPE_TAG))
+ _logger.debug("No value specified for "+JMSEpr.JNDI_TYPE_TAG+" attribute"
+ +" - Using default of: '"+_jndiType+"'");
_jndiURL = obtainAttribute (JMSEpr.JNDI_URL_TAG ,"localhost");
+ if (null==_config.getAttribute(JMSEpr.JNDI_URL_TAG))
+ _logger.debug("No value specified for "+JMSEpr.JNDI_URL_TAG+" attribute"
+ +" - Using default of: '"+_jndiURL+"'");
_jndiCtx = AppServerContext.getServerContext(_jndiType,_jndiURL);
_jmsFactoryClass = obtainAttribute(JMSEpr.CONNECTION_FACTORY_TAG, "ConnectionFactory");
+ if (null==_config.getAttribute(JMSEpr.CONNECTION_FACTORY_TAG))
+ _logger.debug("No value specified for "+JMSEpr.CONNECTION_FACTORY_TAG+" attribute"
+ +" - Using default of: '"+_jmsFactoryClass+"'");
_epr = new JMSEpr(JMSEpr.QUEUE_TYPE,_queueName,_jmsFactoryClass
,_jndiType,_jndiURL,_sSelector);
More information about the jboss-svn-commits
mailing list