[jboss-svn-commits] JBoss Portal SVN: r5365 - trunk/server/src/main/org/jboss/portal/server/servlet

[jboss-svn-commits at lists.jboss.org]

Author: julien at jboss.com
Date: 2006-10-08 19:46:17 -0400 (Sun, 08 Oct 2006)
New Revision: 5365

Modified:
   trunk/server/src/main/org/jboss/portal/server/servlet/PortalServlet.java
Log:
minor optimization : avoid to create an hashmap when the request body is empty, instead use Collections.EMPTY_MAP

Modified: trunk/server/src/main/org/jboss/portal/server/servlet/PortalServlet.java
===================================================================
--- trunk/server/src/main/org/jboss/portal/server/servlet/PortalServlet.java	2006-10-08 23:39:46 UTC (rev 5364)
+++ trunk/server/src/main/org/jboss/portal/server/servlet/PortalServlet.java	2006-10-08 23:46:17 UTC (rev 5365)
@@ -265,7 +265,7 @@
       Map bodyParameterMap = null;
       if (method == POST_METHOD && PortalConstants.APPLICATION_X_WWW_FORM_URLENCODED.equals(mediaType))
       {
-         bodyParameterMap = new HashMap();
+         bodyParameterMap = Collections.EMPTY_MAP;
          for (Iterator i = req.getParameterMap().entrySet().iterator(); i.hasNext();)
          {
             Map.Entry entry = (Map.Entry)i.next();
@@ -285,6 +285,10 @@
                {
                   String[] bodyValues = new String[bodyValuesLength];
                   System.arraycopy(paramValues, queryValues.length, bodyValues, 0, bodyValuesLength);
+                  if (bodyParameterMap.isEmpty())
+                  {
+                     bodyParameterMap = new HashMap();
+                  }
                   bodyParameterMap.put(paramName, bodyValues);
                }
             }
@@ -295,7 +299,7 @@
          }
 
          // Make the map unmodifiable
-         bodyParameterMap = Collections.unmodifiableMap(bodyParameterMap);
+         bodyParameterMap = bodyParameterMap.isEmpty() ? bodyParameterMap : Collections.unmodifiableMap(bodyParameterMap);
       }
 
       // ***************