[jboss-svn-commits] JBL Code SVN: r6908 - labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners
jboss-svn-commits at lists.jboss.org
jboss-svn-commits at lists.jboss.org
Thu Oct 19 08:28:35 EDT 2006
Author: estebanschifman
Date: 2006-10-19 08:28:30 -0400 (Thu, 19 Oct 2006)
New Revision: 6908
Added:
labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerTagNames.java
Removed:
labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerPropertyNames.java
Modified:
labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ActionProcessingPipeline.java
labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/EsbListenerController.java
labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/JmsQueueListener.java
Log:
Tidy up code and class names
Modified: labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ActionProcessingPipeline.java
===================================================================
--- labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ActionProcessingPipeline.java 2006-10-19 00:32:57 UTC (rev 6907)
+++ labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ActionProcessingPipeline.java 2006-10-19 12:28:30 UTC (rev 6908)
@@ -35,7 +35,7 @@
_config = ActionUtils.getConfigTree(_message);
if (null==_config)
throw new IllegalArgumentException("Configuration needed for action classes");
- _actionList = _config.getChildren(ListenerPropertyNames.ACTION_ELEMENT);
+ _actionList = _config.getChildren(ListenerTagNames.ACTION_ELEMENT);
if (null==_actionList || _actionList.length<1)
throw new ConfigurationException("No actions in list");
}
@@ -67,10 +67,10 @@
for(ConfigTree oCurr : _actionList)
{
_currentIndex++;
- String attrName = ListenerPropertyNames.ACTION_CLASS_ATTRIBUTE;
+ String attrName = ListenerTagNames.ACTION_CLASS_ATTRIBUTE;
_currentAction = oCurr.getAttribute(attrName);
- attrName = ListenerPropertyNames.ACTION_PROCESS_METHOD;
+ attrName = ListenerTagNames.ACTION_PROCESS_METHOD;
String sProcessMethod = obtainAttribute(oCurr,attrName,attrName);
_currentClass = Class.forName(_currentAction);
@@ -141,7 +141,7 @@
protected void actionClassException(ConfigTree tree, Exception thr)
{
thr.printStackTrace();
- String sMethod = obtainAttribute(tree,ListenerPropertyNames.ACTION_EXCEPTION_CALLBACK,null);
+ String sMethod = obtainAttribute(tree,ListenerTagNames.ACTION_EXCEPTION_CALLBACK,null);
if (null!=sMethod)
try
{
@@ -160,7 +160,7 @@
*/
protected void actionClassFinishedOk(ConfigTree tree)
{
- String sMethod = obtainAttribute(tree,ListenerPropertyNames.ACTION_NORMAL_COMPLETION_CALLBACK,null);
+ String sMethod = obtainAttribute(tree,ListenerTagNames.ACTION_NORMAL_COMPLETION_CALLBACK,null);
if (null!=sMethod)
try
{
@@ -177,7 +177,7 @@
String[] sa = new String[_actionList.length];
int i1=0;
for (ConfigTree oCurr : _actionList)
- sa[i1++]=obtainAttribute(oCurr,ListenerPropertyNames.ACTION_CLASS_ATTRIBUTE,"NO_CLASSNAME");
+ sa[i1++]=obtainAttribute(oCurr,ListenerTagNames.ACTION_CLASS_ATTRIBUTE,"NO_CLASSNAME");
return sa;
}
Modified: labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/EsbListenerController.java
===================================================================
--- labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/EsbListenerController.java 2006-10-19 00:32:57 UTC (rev 6907)
+++ labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/EsbListenerController.java 2006-10-19 12:28:30 UTC (rev 6908)
@@ -152,10 +152,9 @@
private static CommandQueue defaultCommandQueue = null;
/**
- * Package pivate default constructor.
+ * No default constructor - only for child classes
*/
- protected EsbListenerController() {
- }
+ protected EsbListenerController() { }
/**
* Construct a Listener Manager from the named repository based
Modified: labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/JmsQueueListener.java
===================================================================
--- labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/JmsQueueListener.java 2006-10-19 00:32:57 UTC (rev 6907)
+++ labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/JmsQueueListener.java 2006-10-19 12:28:30 UTC (rev 6908)
@@ -114,7 +114,7 @@
// Default value of obtainAttribute is null - Exception will be thrown
String sQueue = obtainAttribute(JMSEpr.DESTINATION_NAME_TAG, null);
- _eprName = obtainAttribute(ListenerPropertyNames.EPR_NAME,null);
+ _eprName = obtainAttribute(ListenerTagNames.EPR_IN_NAME,null);
// No problem if selector is null - everything in queue will be returned
_sSelector = _config.getAttribute(JMSEpr.MESSAGE_SELECTOR_TAG);
Deleted: labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerPropertyNames.java
===================================================================
--- labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerPropertyNames.java 2006-10-19 00:32:57 UTC (rev 6907)
+++ labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerPropertyNames.java 2006-10-19 12:28:30 UTC (rev 6908)
@@ -1,12 +0,0 @@
-package org.jboss.soa.esb.message.listeners;
-
-public class ListenerPropertyNames
-{
- public static final String EPR_NAME = "epr-name";
-
- public static final String ACTION_ELEMENT = "action";
- public static final String ACTION_CLASS_ATTRIBUTE = "class";
- public static final String ACTION_PROCESS_METHOD = "process";
- public static final String ACTION_NORMAL_COMPLETION_CALLBACK = "okMethod";
- public static final String ACTION_EXCEPTION_CALLBACK= "exceptionMethod";
-}
Copied: labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerTagNames.java (from rev 6891, labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerPropertyNames.java)
===================================================================
--- labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerPropertyNames.java 2006-10-18 14:54:49 UTC (rev 6891)
+++ labs/jbossesb/workspace/eschifman/trunk/product/core/listeners/src/org/jboss/soa/esb/message/listeners/ListenerTagNames.java 2006-10-19 12:28:30 UTC (rev 6908)
@@ -0,0 +1,13 @@
+package org.jboss.soa.esb.message.listeners;
+
+public class ListenerTagNames
+{
+ public static final String EPR_IN_NAME = "epr-in-name";
+ public static final String EPR_OUT_NAME = "epr-out-name";
+
+ public static final String ACTION_ELEMENT = "action";
+ public static final String ACTION_CLASS_ATTRIBUTE = "class";
+ public static final String ACTION_PROCESS_METHOD = "process";
+ public static final String ACTION_NORMAL_COMPLETION_CALLBACK = "okMethod";
+ public static final String ACTION_EXCEPTION_CALLBACK= "exceptionMethod";
+}
More information about the jboss-svn-commits
mailing list