[jboss-svn-commits] JBL Code SVN: r6957 - in labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client: . common rpc rulelist

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2006-10-20 10:12:23 -0400 (Fri, 20 Oct 2006)
New Revision: 6957

Removed:
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/common/TableHeaderSortWidget.java
Modified:
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/Rules.java
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rpc/RepositoryServiceFactory.java
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleItemListViewer.java
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleListView.java
Log:
minor refactoring

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/Rules.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/Rules.java	2006-10-20 14:06:07 UTC (rev 6956)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/Rules.java	2006-10-20 14:12:23 UTC (rev 6957)
@@ -12,13 +12,14 @@
 import com.google.gwt.user.client.ui.HasHorizontalAlignment;
 import com.google.gwt.user.client.ui.HasVerticalAlignment;
 import com.google.gwt.user.client.ui.Image;
-import com.google.gwt.user.client.ui.Label;
-import com.google.gwt.user.client.ui.SimplePanel;
 import com.google.gwt.user.client.ui.TabPanel;
 import com.google.gwt.user.client.ui.Widget;
 import com.google.gwt.user.client.ui.FlexTable.FlexCellFormatter;
 
-
+/**
+ * This controls the "Rules manager" top level feature.
+ * @author Michael Neale
+ */
 public class Rules extends JBRMSFeature {
 
     public static final int       EDITOR_TAB         = 1;
@@ -82,7 +83,7 @@
             public void open(String key) {
                 
                 //TODO: this is where we really truly open things.
-                System.out.println("opening key " + key);
+                System.out.println("opening key [" + key + "]");
                 RuleView view = new RuleView();
 
                 String ruleName = "some rule";

Deleted: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/common/TableHeaderSortWidget.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/common/TableHeaderSortWidget.java	2006-10-20 14:06:07 UTC (rev 6956)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/common/TableHeaderSortWidget.java	2006-10-20 14:12:23 UTC (rev 6957)
@@ -1,15 +0,0 @@
-package org.drools.brms.client.common;
-
-import com.google.gwt.user.client.ui.Composite;
-import com.google.gwt.user.client.ui.HorizontalPanel;
-
-public class TableHeaderSortWidget extends Composite {
-
-    
-    private HorizontalPanel panel;
-    
-    public TableHeaderSortWidget(String name) {
-        
-    }
-    
-}

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rpc/RepositoryServiceFactory.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rpc/RepositoryServiceFactory.java	2006-10-20 14:06:07 UTC (rev 6956)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rpc/RepositoryServiceFactory.java	2006-10-20 14:12:23 UTC (rev 6957)
@@ -35,8 +35,7 @@
             (RepositoryServiceAsync) GWT.create(RepositoryService.class);
         ServiceDefTarget endpoint = (ServiceDefTarget) svc;
         
-        String endpointURL = GWT.getModuleBaseURL() + "jbrmsService";
-        System.out.println("Endpoint URL: " + endpointURL);
+        String endpointURL = GWT.getModuleBaseURL() + "jbrmsService";        
         
         endpoint.setServiceEntryPoint(endpointURL);
         return svc;

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleItemListViewer.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleItemListViewer.java	2006-10-20 14:06:07 UTC (rev 6956)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleItemListViewer.java	2006-10-20 14:12:23 UTC (rev 6957)
@@ -1,6 +1,7 @@
 package org.drools.brms.client.rulelist;
 
 import org.drools.brms.client.common.ErrorPopup;
+import org.drools.brms.client.rpc.RepositoryServiceAsync;
 import org.drools.brms.client.rpc.RepositoryServiceFactory;
 import org.drools.brms.client.rpc.TableConfig;
 import org.drools.brms.client.rpc.TableDataResult;
@@ -32,12 +33,13 @@
     private EditItemEvent openItemEvent;
     private String currentSelectedPath;
     private Image refreshIcon;
+    private static RepositoryServiceAsync service = RepositoryServiceFactory.getService();
 
     public RuleItemListViewer(EditItemEvent event) {
 
         init();
 
-        RepositoryServiceFactory.getService().loadTableConfig( "ruleList",
+        service.loadTableConfig( "ruleList",
                                                                new AsyncCallback() {
 
                                                                    public void onFailure(Throwable w) {
@@ -179,7 +181,7 @@
         
 
         
-        RepositoryServiceFactory.getService().loadRuleListForCategories( selectedPath,
+        service .loadRuleListForCategories( selectedPath,
                                                                          "",
                                                                          new AsyncCallback() {
 

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleListView.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleListView.java	2006-10-20 14:06:07 UTC (rev 6956)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/client/rulelist/RuleListView.java	2006-10-20 14:12:23 UTC (rev 6957)
@@ -48,14 +48,13 @@
     private HorizontalPanel        navBar             = new HorizontalPanel();
     
     
-    private final RepositoryServiceAsync service;
+    private static final RepositoryServiceAsync service = RepositoryServiceFactory.getService();
     private String[][] data;
     protected int numberOfColumns;
     private EditItemEvent editEvent;
 
     public RuleListView(EditItemEvent event) {
 
-        service = RepositoryServiceFactory.getService();
         this.editEvent = event;