[jboss-svn-commits] JBoss Portal SVN: r5160 - branches/tomek/portal-dnd/dndRenderer.war/js/portal

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Wed Sep 6 10:28:19 EDT 2006


Author: roy.russo at jboss.com
Date: 2006-09-06 10:28:18 -0400 (Wed, 06 Sep 2006)
New Revision: 5160

Modified:
   branches/tomek/portal-dnd/dndRenderer.war/js/portal/PortalDD.js
Log:
JBPORTAL-1007 - Fix drag & drop code to work in Konqueror / Safari

Modified: branches/tomek/portal-dnd/dndRenderer.war/js/portal/PortalDD.js
===================================================================
--- branches/tomek/portal-dnd/dndRenderer.war/js/portal/PortalDD.js	2006-09-06 14:10:06 UTC (rev 5159)
+++ branches/tomek/portal-dnd/dndRenderer.war/js/portal/PortalDD.js	2006-09-06 14:28:18 UTC (rev 5160)
@@ -15,13 +15,10 @@
 }
 
 function getBorder(id) {
-    log.log("getBorder...", "info");	
-    if (!borderSet) {
-      setBorder(id);
-    }
+    log.log("getBorder...", "info");
 
-	YAHOO.util.Dom.setStyle(id, "border-top", "2px solid red");
-	YAHOO.util.Dom.setStyle(id, "border", "");
+	YAHOO.util.Dom.setStyle(id, "border-top", "0px");
+	YAHOO.util.Dom.setStyle(id, "border", "0px");
     borderBefore = "";
     borderTopBefore = "";
     borderSet = false;
@@ -33,42 +30,45 @@
     	borderBefore = YAHOO.util.Dom.getStyle(id, "border");
     	borderSet = true;
     }
-    
-    YAHOO.util.Dom.setStyle(id, "border-top", "2px solid red");
+
+    //YAHOO.util.Dom.setStyle(id, "border-top", "2px solid red");
+    //YAHOO.util.Dom.setStyle(id, "border-top", "2px dashed red");
+    YAHOO.util.Dom.setStyle(id, "border", "2px dashed green");
+
 }
 
 function persitNewPosition(positionNo, windowId, oldRegionId, newRegionId) {
 	postData = "action=PERSIST&positionNo="+encodeURI(positionNo)+"&windowId="+encodeURI(windowId)+"&oldRegionId="+encodeURI(oldRegionId)+"&newRegionId="+encodeURI(newRegionId);
-	
+
 	log.log(postData);
 	invokeAjax(postData);
 }
 
 function invokeAjax(postData) {
 	if (ajaxEnabled) {
-	    var handleSuccess = function(o){ 
-		 
-		    if(o.responseText !== undefined){ 
-		        log.log("Transaction id: " + o.tId); 
-		        log.log("HTTP status: " + o.status); 
-		        log.log("Status code message: " + o.statusText); 
-		        log.log("<li>HTTP headers: <ul>" + o.getAllResponseHeaders + "</ul></li>"); 
-		        log.log("Servlet response: " + o.responseText); 
-		        log.log("Argument object: " + o.argument); 
-		    } 
-		} 
-		
+	    var handleSuccess = function(o){
+
+		    if(o.responseText !== undefined){
+		        log.log("Transaction id: " + o.tId);
+		        log.log("HTTP status: " + o.status);
+		        log.log("Status code message: " + o.statusText);
+		        log.log("<li>HTTP headers: <ul>" + o.getAllResponseHeaders + "</ul></li>");
+		        log.log("Servlet response: " + o.responseText);
+		        log.log("Argument object: " + o.argument);
+		    }
+		}
+
 		var handleFailure = function(o) {
 			log.log("Failure: " + o);
 		}
-		 
-		var callback = 
-		{ 
-		  success:handleSuccess, 
-		  failure: handleFailure, 
-		  argument: [] 
-		}; 
-		
+
+		var callback =
+		{
+		  success:handleSuccess,
+		  failure: handleFailure,
+		  argument: []
+		};
+
 		var request = YAHOO.util.Connect.asyncRequest('POST', host+ajaxURI, callback, postData);
 	}
 }
@@ -84,57 +84,57 @@
 
 YAHOO.util.PortalDD.prototype.onDragOver = function(e, id) {
     YAHOO.util.PortalDD.superclass.onDragOver.call(this, e, id);
-    
+
     // draw a border around dropto portlet
     setBorder(id);
 }
 
 YAHOO.util.PortalDD.prototype.onDragOut = function(e, id) {
     YAHOO.util.PortalDD.superclass.onDragOut.call(this, e, id);
-    
+
     // remove the border around dropto portlet
     getBorder(id);
 }
 
 YAHOO.util.PortalDD.prototype.onDragDrop = function(e, id) {
     log.log("in PortalDD onDragDrop", "info");
-    
+
     // remove the border around dropto portlet
     getBorder(id);
-    
+
     var el = this.getEl();
 	var droped = document.getElementById(id);
-	
+
 	var thisParent = el.parentNode;
 	var dropedParent = droped.parentNode;
 
 	// show region droper if needed
 	if (thisParent.childNodes.length == 2) {
 		var regToDrop = document.getElementById(thisParent.dropToRegion);
-	
+
 		YAHOO.util.Dom.setStyle(regToDrop, "display", "block");
 		YAHOO.util.Dom.setStyle(regToDrop, "visibility", "");
 	}
-    
+
 	thisParent.removeChild(el);
 	dropedParent.appendChild(el);
-	
+
 	// hide region droper if needed
 	if (dropedParent.childNodes.length == 2) {
 		var regToDrop = document.getElementById(dropedParent.dropToRegion);
-	
+
 		YAHOO.util.Dom.setStyle(regToDrop, "display", "none");
 		YAHOO.util.Dom.setStyle(regToDrop, "visibility", "hidden");
-	} 
+	}
 	log.log("AFTER Parent: " + el.parentNode + "(" + el.parentNode.id +")"+" droped: " + droped.parentNode + "(" + droped.parentNode.id +")");
-	
+
 	log.log( "position: " + YAHOO.util.Dom.getStyle(el, "position"));
 	YAHOO.util.Dom.setStyle(el, "position", "static");
-	
+
 	var nodeList = dropedParent.childNodes;
-	
+
 	var adding = false;YAHOO.util.PortalDD
-	
+
 	// move down all the nodes under the portlet (including dropto portlet)
 	var i = 0;
 	while ((nodeList.item(i) != el) && (i < nodeList.length)) {
@@ -142,7 +142,7 @@
 		if (!adding && nextNode == droped) {
 			adding = true;
 		}
-		
+
 		if (adding) {
 			dropedParent.appendChild(nextNode);
 		}
@@ -150,20 +150,20 @@
 			i++;
 		}
 	}
-	
+
 	if (nodeList.item(0).id.indexOf("regionDrop") == 0) {
 		i--;
 	}
-	
+
 	log.log("new position: "+i+ " " + this.windowId);
 	persitNewPosition(i, this.windowId, thisParent.regionId, dropedParent.regionId);
 };
 
 YAHOO.util.PortalDD.prototype.endDrag = function(e) {
-	// PortalDD changes 
+	// PortalDD changes
 	// Don't move the portlet - it'll be placed by the browser
 	// Just remove the proxy frame
-	
+
     var DOM = YAHOO.util.Dom;
     this.logger.log(this.id + " endDrag");
     //var lel = this.getEl();
@@ -171,37 +171,37 @@
 
     // Show the drag frame briefly so we can get its position
     // del.style.visibility = "";
-    DOM.setStyle(del, "visibility", ""); 
+    DOM.setStyle(del, "visibility", "");
 
-    // Hide the linked element before the move to get around a Safari 
+    // Hide the linked element before the move to get around a Safari
     // rendering bug.
     //lel.style.visibility = "hidden";
-    //DOM.setStyle(lel, "visibility", "hidden"); 
+    //DOM.setStyle(lel, "visibility", "hidden");
     //YAHOO.util.DDM.moveToEl(lel, del);
     //del.style.visibility = "hidden";
-    DOM.setStyle(del, "visibility", "hidden"); 
+    DOM.setStyle(del, "visibility", "hidden");
     //lel.style.visibility = "";
-    //DOM.setStyle(lel, "visibility", ""); 
+    //DOM.setStyle(lel, "visibility", "");
 };
 
 // cleans up regionDD renderer from some crap wrongly intepreted by a browser
 function cleanUpDocument(id) {
 	var region = document.getElementById(id);
 	var nodeList = region.childNodes;
-
+/*
 	// move down all the nodes under the portlet (including dropto portlet)
-//	var i = 0;
-//	while (i < nodeList.length) {
-//		var nextNode = nodeList.item(i);
-//
-//		log.log(nextNode, "warn");
-//		if (nextNode instanceof Text) {
-//			log.log("next one: "+id+" "+ i);
-//			region.removeChild(nextNode);
-//		}
-//		else {
-//			i++;
-//		}
-//	}
+	var i = 0;
+	while (i < nodeList.length) {
+		var nextNode = nodeList.item(i);
 
+		log.log(nextNode, "warn");
+		if (nextNode instanceof Text) {
+			log.log("next one: "+id+" "+ i);
+			region.removeChild(nextNode);
+		}
+		else {
+			i++;
+		}
+	}
+*/
 }




More information about the jboss-svn-commits mailing list