[jboss-svn-commits] JBL Code SVN: r14187 - labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui.

[jboss-svn-commits at lists.jboss.org]

Author: arhan
Date: 2007-08-13 15:57:49 -0400 (Mon, 13 Aug 2007)
New Revision: 14187

Modified:
   labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewActionDialog.java
   labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewConditionDialog.java
Log:
JBRULES-1069: DSLSentence.copy() should be used when adding the new sentece to the model via UI

Modified: labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewActionDialog.java
===================================================================
--- labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewActionDialog.java	2007-08-13 18:02:52 UTC (rev 14186)
+++ labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewActionDialog.java	2007-08-13 19:57:49 UTC (rev 14187)
@@ -151,7 +151,8 @@
                                               return;
                                           }
 
-                                          modeller.getModel().addRhsItem( getCompletion().getDSLActions()[dslCombo.getSelectionIndex() - 1] );
+                                          DSLSentence sentence = getCompletion().getDSLActions()[dslCombo.getSelectionIndex() - 1];
+										  modeller.getModel().addRhsItem( sentence.copy() );
                                           modeller.setDirty( true );
                                           modeller.reloadRhs();
                                           close();

Modified: labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewConditionDialog.java
===================================================================
--- labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewConditionDialog.java	2007-08-13 18:02:52 UTC (rev 14186)
+++ labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/rulebuilder/ui/AddNewConditionDialog.java	2007-08-13 19:57:49 UTC (rev 14187)
@@ -130,8 +130,9 @@
                                               return;
                                           }
 
-                                          //TODO Handle this kind of situations with care - add* can throw runtime exceptions
-                                          modeller.getModel().addLhsItem( getCompletion().getDSLConditions()[dslCombo.getSelectionIndex() - 1] );
+                                          DSLSentence sentence = getCompletion().getDSLConditions()[dslCombo.getSelectionIndex() - 1];
+										//TODO Handle this kind of situations with care - add* can throw runtime exceptions
+                                          modeller.getModel().addLhsItem( sentence.copy() );
 
                                           modeller.reloadLhs();
                                           modeller.setDirty( true );