[jboss-svn-commits] JBL Code SVN: r9234 - in labs/jbossrules/trunk/drools-repository/src: main/resources/node_type_definitions and 1 other directories.

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2007-01-31 19:09:56 -0500 (Wed, 31 Jan 2007)
New Revision: 9234

Modified:
   labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/PackageItem.java
   labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/VersionableItem.java
   labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rule_node_type.cnd
   labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rulepackage_node_type.cnd
   labs/jbossrules/trunk/drools-repository/src/test/java/org/drools/repository/PackageItemTest.java
Log:
JBRULES-633 package configuration

Modified: labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/PackageItem.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/PackageItem.java	2007-02-01 00:08:40 UTC (rev 9233)
+++ labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/PackageItem.java	2007-02-01 00:09:56 UTC (rev 9234)
@@ -55,6 +55,8 @@
      * The folder where functions are kept
      */
     public static final String FUNCTION_FOLDER_NAME             = "functions";
+    
+    public static final String HEADER_PROPERTY_NAME             = "drools:header";
 
     /**
      * Constructs an object of type RulePackageItem corresponding the specified node
@@ -514,6 +516,22 @@
     }
     
     /**
+     * @return The header contents as pertains to a package of rule assets.
+     */
+    public String getHeader() {
+        return this.getStringProperty( HEADER_PROPERTY_NAME );
+    }
+    
+    /**
+     * Update the header property.
+     */
+    public void updateHeader(String header) {
+        checkIsUpdateable();
+        checkout();
+        updateStringProperty( header, HEADER_PROPERTY_NAME );
+    }
+    
+    /**
      * This will create a new version of a package, effectively freezing the state.
      * This means in the "head" version of the package, rules can be added
      * removed, without effecting the baseline that was created.

Modified: labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/VersionableItem.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/VersionableItem.java	2007-02-01 00:08:40 UTC (rev 9233)
+++ labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/VersionableItem.java	2007-02-01 00:09:56 UTC (rev 9234)
@@ -346,14 +346,7 @@
      * This will return the checkin comment for the latest revision.
      */
     public String getCheckinComment() throws RulesRepositoryException {
-        try {
-            Property data = getVersionContentNode().getProperty( CHECKIN_COMMENT );
-            return data.getValue().getString();
-        } catch ( Exception e ) {
-            log.error( "Caught Exception",
-                       e );
-            throw new RulesRepositoryException( e );
-        }
+        return getStringProperty( CHECKIN_COMMENT );
     }
 
     /**

Modified: labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rule_node_type.cnd
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rule_node_type.cnd	2007-02-01 00:08:40 UTC (rev 9233)
+++ labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rule_node_type.cnd	2007-02-01 00:09:56 UTC (rev 9234)
@@ -14,10 +14,8 @@
 > 'drools:versionableNodeType'
 
 
-
 // Properties:
 - drools:content (string)
-
   
 // use this to capture fields which are not known ahead of time 
 - * (undefined)

Modified: labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rulepackage_node_type.cnd
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rulepackage_node_type.cnd	2007-02-01 00:08:40 UTC (rev 9233)
+++ labs/jbossrules/trunk/drools-repository/src/main/resources/node_type_definitions/rulepackage_node_type.cnd	2007-02-01 00:09:56 UTC (rev 9234)
@@ -20,8 +20,12 @@
 + * (drools:versionableAssetFolder)
   copy
 
+// this is for storing misc header info as pertains to rules, specifically imports
+- drools:header (string)
 
-/* MN: retiring this structure  - may use it in future for shared rules
+
+
+/* MN: retiring this structure  - use it in future for shared rules
 - drools:ruleReference (reference)
   multiple
   copy

Modified: labs/jbossrules/trunk/drools-repository/src/test/java/org/drools/repository/PackageItemTest.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/test/java/org/drools/repository/PackageItemTest.java	2007-02-01 00:08:40 UTC (rev 9233)
+++ labs/jbossrules/trunk/drools-repository/src/test/java/org/drools/repository/PackageItemTest.java	2007-02-01 00:09:56 UTC (rev 9234)
@@ -449,6 +449,15 @@
     }
 
     
+    public void testHeader() {
+        PackageItem item = getRepo().createPackage( "testHeader", "ya" );
+        
+        item.updateHeader( "new header" );
+        getRepo().save();
+        assertEquals("new header", item.getHeader());
+        item = getRepo().loadPackage("testHeader");
+        assertEquals("new header", item.getHeader());
+    }
     
     public void testGetFormat() {        
             PackageItem rulePackageItem1 = getRepo().createPackage("testGetFormat", "woot");