[jboss-svn-commits] JBL Code SVN: r13099 - in labs/jbossrules/trunk/drools-compiler/src: test/java/org/drools/compiler and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2007-07-05 00:29:05 -0400 (Thu, 05 Jul 2007)
New Revision: 13099

Added:
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/RuleErrorTest.java
Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/RuleError.java
Log:
JBRULES-553

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/RuleError.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/RuleError.java	2007-07-05 03:33:03 UTC (rev 13098)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/RuleError.java	2007-07-05 04:29:05 UTC (rev 13099)
@@ -66,7 +66,11 @@
         if ( this.object instanceof CompilationProblem[] ) {
             final CompilationProblem[] problem = (CompilationProblem[]) this.object;
             for ( int i = 0; i < problem.length; i++ ) {
-                summary = summary + " " + problem[i].getMessage();
+                if (i != 0) {
+                    summary = summary + "\n" + problem[i].getMessage();
+                } else {
+                    summary = summary + " " + problem[i].getMessage();
+                }
             }
 
         }

Added: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/RuleErrorTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/RuleErrorTest.java	                        (rev 0)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/RuleErrorTest.java	2007-07-05 04:29:05 UTC (rev 13099)
@@ -0,0 +1,65 @@
+package org.drools.compiler;
+
+import org.drools.commons.jci.problems.CompilationProblem;
+import org.drools.lang.descr.AndDescr;
+import org.drools.rule.Rule;
+
+import junit.framework.TestCase;
+
+public class RuleErrorTest extends TestCase {
+
+    public void testNewLineInMessage() {
+        CompilationProblem[] probs = new CompilationProblem[3];
+        probs[0] = new MockCompilationProblem();
+        probs[1] = new MockCompilationProblem();
+        probs[2] = new MockCompilationProblem();
+
+        
+        RuleError err = new RuleError(new Rule("ruleName"), 
+                                      new AndDescr(), 
+                                      probs, 
+                                      "IM IN YR EROR");
+        assertNotNull(err.toString());
+        String msg = err.getMessage();
+        
+        assertTrue(msg.indexOf( "IM IN YR EROR") != -1);
+        System.err.println(msg);        
+        assertEquals("IM IN YR EROR problem\nproblem\nproblem", msg);
+
+        
+    }
+    
+    
+    class MockCompilationProblem implements CompilationProblem {
+
+        public int getEndColumn() {
+            return 0;
+        }
+
+        public int getEndLine() {
+            return 0;
+        }
+
+        public String getFileName() {
+            return "X";
+        }
+
+        public String getMessage() {
+            return "problem";
+        }
+
+        public int getStartColumn() {
+            return 0;
+        }
+
+        public int getStartLine() {
+            return 0;
+        }
+
+        public boolean isError() {
+            return true;
+        }
+        
+    }
+    
+}


Property changes on: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/RuleErrorTest.java
___________________________________________________________________
Name: svn:eol-style
   + native