[jboss-svn-commits] JBL Code SVN: r15578 - in labs/jbossrules/trunk/drools-compiler/src: test/resources/org/drools/xml and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: fmeyer
Date: 2007-10-04 07:56:47 -0400 (Thu, 04 Oct 2007)
New Revision: 15578

Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/LiteralRestrictionHandler.java
   labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/xml/test_ParseRule.xml
Log:
JBRULES-1248  <literal-restriction> requires an 'value' attribute, but it can't be null


Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/LiteralRestrictionHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/LiteralRestrictionHandler.java	2007-10-04 11:18:18 UTC (rev 15577)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/LiteralRestrictionHandler.java	2007-10-04 11:56:47 UTC (rev 15578)
@@ -72,10 +72,6 @@
         }
 
         final String text = attrs.getValue( "value" );
-        if ( text == null || text.trim().equals( "" ) ) {
-            throw new SAXParseException( "<literal-restriction>  requires an 'value' attribute",
-                                         this.xmlPackageReader.getLocator() );
-        }
 
         final LiteralRestrictionDescr literalDescr = new LiteralRestrictionDescr( evaluator,
                                                                                   text );

Modified: labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/xml/test_ParseRule.xml
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/xml/test_ParseRule.xml	2007-10-04 11:18:18 UTC (rev 15577)
+++ labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/xml/test_ParseRule.xml	2007-10-04 11:56:47 UTC (rev 15578)
@@ -149,4 +149,34 @@
 	</rhs>
 </rule>
 
+<rule name="Check_NotNullof_rfqId">
+
+<rule-attribute name="agenda-group" value="Check" />
+
+<lhs><pattern object-type="RFQBean" >
+
+<or-constraint-connective><field-constraint field-name="m_rfqId">
+
+<literal-restriction evaluator="==" value="null" />
+
+</field-constraint>
+
+<field-constraint field-name="m_rfqId">
+
+<literal-restriction evaluator="==" value="" />
+
+</field-constraint>
+
+</or-constraint-connective>
+
+</pattern>
+
+</lhs><rhs> response.setStatus("For RFQ Bean: The value of m_rfqId is null.");
+
+System.out.println(response.getStatus());
+
+</rhs>
+
+</rule>
+
 </package>