[jboss-svn-commits] JBL Code SVN: r15256 - in labs/jbossrules/trunk/drools-examples/drools-insurance/src: test/java/org/acme/insurance/test and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: fmeyer
Date: 2007-09-20 02:01:25 -0400 (Thu, 20 Sep 2007)
New Revision: 15256

Modified:
   labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/DroolsBusiness.java
   labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/InsuranceSessionHelper.java
   labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverAdditionalInfoTest.java
   labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverTest.java
Log:
Refactoring the example to be more smart


Modified: labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/DroolsBusiness.java
===================================================================
--- labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/DroolsBusiness.java	2007-09-20 05:46:18 UTC (rev 15255)
+++ labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/DroolsBusiness.java	2007-09-20 06:01:25 UTC (rev 15256)
@@ -105,6 +105,7 @@
 				+ driverMale.getInsuranceFactor());
 		System.out.println("Is Approved     : " + policy.isApproved());
 		System.out.println("Insurance Price :" + policy.getInsurancePrice());
-
+		
+		session.dispose();
 	}
 }

Modified: labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/InsuranceSessionHelper.java
===================================================================
--- labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/InsuranceSessionHelper.java	2007-09-20 05:46:18 UTC (rev 15255)
+++ labs/jbossrules/trunk/drools-examples/drools-insurance/src/main/java/org/acme/insurance/web/InsuranceSessionHelper.java	2007-09-20 06:01:25 UTC (rev 15256)
@@ -9,18 +9,14 @@
     private static StatefulSession session;
     
     private InsuranceSessionHelper(){
-        
     }
 
     public static StatefulSession getSession() {
     	
-    	if (rulebase == null ) { 
-	        try {
-	        	rulebase = loadRuleBaseFromRuleAgent();
-	        } catch ( Exception e ) {
-	            e.printStackTrace();
-	        }
+    	if ( rulebase == null ) { 
+    		rulebase = loadRuleBaseFromRuleAgent();
     	}
+    	
         session = rulebase.newStatefulSession();
         session.startProcess( "insuranceProcess" );
         return session;
@@ -31,33 +27,4 @@
         RuleBase rulebase = agent.getRuleBase();
         return rulebase;
     }
-
-
-// Use the following methods to load the rulebase from the drl files    
-    
-//    private RuleBase loadRuleBaseFromDRL() throws Exception {
-//
-//        PackageBuilder builder = new PackageBuilder();
-//        builder.addPackageFromDrl( getTechnicalRules( "/approval/insurancefactor.drl" ) );
-//        builder.addPackageFromDrl( getTechnicalRules( "/approval/approval.drl" ) );
-//        builder.addPackageFromDrl( getTechnicalRules( "/approval/calculateInsurance.drl" ) );
-//        builder.addPackageFromDrl( getTechnicalRules( "/approval/marginalage.dslr" ),
-//                                   getTechnicalRules( "/approval/acme.dsl" ) );
-//        builder.addRuleFlow( getTechnicalRules( "/approval/insurance-process.rfm" ) );
-//
-//        
-//
-//        RuleBase ruleBase = RuleBaseFactory.newRuleBase();
-//        ruleBase.addPackage( builder.getPackage() );
-//        return ruleBase;
-//    }
-
-//    private Reader getTechnicalRules(String name) {
-//
-//        InputStream stream = this.getClass().getResourceAsStream( name );
-//
-//        return new InputStreamReader( stream );
-//
-//    }
-
 }

Modified: labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverAdditionalInfoTest.java
===================================================================
--- labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverAdditionalInfoTest.java	2007-09-20 05:46:18 UTC (rev 15255)
+++ labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverAdditionalInfoTest.java	2007-09-20 06:01:25 UTC (rev 15256)
@@ -27,7 +27,7 @@
     @Override
     protected void tearDown() throws Exception {
         super.tearDown();
-//        session.dispose();
+        session.dispose();
     }
 
     public void testDriveVehiclePlace() throws 

Modified: labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverTest.java
===================================================================
--- labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverTest.java	2007-09-20 05:46:18 UTC (rev 15255)
+++ labs/jbossrules/trunk/drools-examples/drools-insurance/src/test/java/org/acme/insurance/test/DriverTest.java	2007-09-20 06:01:25 UTC (rev 15256)
@@ -29,7 +29,7 @@
     @Override
     protected void tearDown() throws Exception {
         super.tearDown();
-        //session.dispose();
+        session.dispose();
     }
 
     public void testDriverGenreFactor() throws