[jboss-svn-commits] JBL Code SVN: r24184 - in labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer: metadata and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: beve
Date: 2008-12-01 10:19:38 -0500 (Mon, 01 Dec 2008)
New Revision: 24184

Modified:
   labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbDeployment.java
   labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbParserDeployer.java
   labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbRuntimeDeployer.java
   labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/metadata/EsbMetaData.java
Log:
Minor updates.


Modified: labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbDeployment.java
===================================================================
--- labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbDeployment.java	2008-12-01 14:58:33 UTC (rev 24183)
+++ labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbDeployment.java	2008-12-01 15:19:38 UTC (rev 24184)
@@ -27,19 +27,13 @@
 import org.jboss.esb.util.AssertArgument;
 
 /**
- * An EsbDeployment is a MicroContainer deployment that wraps
- * an ESB DeploymentUnit and methods for starting and stoping an {@link EsbRuntimeDeployment}
+ * An EsbDeployment is a MicroContainer (MC) deployment that wraps
+ * an ESB DeploymentUnit and implements MC lifecycle methods starting and
+ * stopping an {@link EsbRuntimeDeployment}
  * <p/>
  * An EsbDeployment is created by the Microcontainer and the Microcontainer
- * is also responsible for the lifecycle events, like starting and stopping.
+ * is also responsible for the lifecycle events, like createing, starting, and stopping.
  *
- * <h1>Lifecycle</h1>
- * Starting an EsbDeployment will deploy the EsbRuntimeDeployment hence staring
- * the {@link EsbRuntimeDeployment}
- *
- * Stopping an EsbDeployment will undeploy the EsbRuntimeDeployment hence
- * undeploying the {@link EsbRuntimeDeployment}
- *
  * @author <a href="mailto:dbevenius at jboss.com">Daniel Bevenius</a>
  * @since 5.0
  */
@@ -76,21 +70,30 @@
     }
 
     /**
-     * Deploys the EsbRuntimeDeployment when called by the MicroContainer.
+     * Creates the EsbDeploymentRuntime when called by the MicroContainer lifecycle.
      *
      * @throws DeploymentException
      */
-    public void start() throws DeploymentException
+    public void create() throws DeploymentException
     {
         // TODO: Fix classloading..make it play nicely with MC. Daniel
         runtime = new DeploymentRuntime(new DeploymentUnitResourceLocator(getClass().getClassLoader()));
         runtime.setDeploymentName(archiveName);
         runtime.addDeploymentUnit(deploymentUnit);
+    }
+
+    /**
+     * Deploys the EsbRuntimeDeployment when called by the MicroContainer lifecycle.
+     *
+     * @throws DeploymentException
+     */
+    public void start() throws DeploymentException
+    {
         runtime.deploy();
     }
 
     /**
-     * Undeploys the EsbRuntimeDeployment when called by the MicroContainer.
+     * Undeploys the EsbRuntimeDeployment when called by the MicroContainer lifecycle.
      *
      * @throws DeploymentException
      */

Modified: labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbParserDeployer.java
===================================================================
--- labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbParserDeployer.java	2008-12-01 14:58:33 UTC (rev 24183)
+++ labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbParserDeployer.java	2008-12-01 15:19:38 UTC (rev 24184)
@@ -41,10 +41,6 @@
  * and produces an {@link EsbMetaData} instance.
  * <p/>
  *
- * The reason for creating the EsbMetaData is to allow other types of Deployers
- * to create the metadata by other means, for example through alternative
- * configurations, annotations, other languages, etc.
- *
  * Sample configuration:
  * <pre>{@code
  *  <bean name="EsbParserDeployer" class="org.jboss.esb.microcontainer.deployers.EsbParserDeployer"/>
@@ -96,7 +92,6 @@
     protected EsbMetaData parse(final VFSDeploymentUnit deploymentUnit, final VirtualFile file, final EsbMetaData metaData) throws DeploymentException
     {
         final DeploymentUnit esbDeploymentUnit = createEsbDeploymentUnit(deploymentUnit, file);
-
         return new EsbMetaData(esbDeploymentUnit, file.getPathName());
     }
 
@@ -151,7 +146,6 @@
 
     private static class EsbConfigFileFilter implements VirtualFileFilter
     {
-
         public boolean accepts(VirtualFile file)
         {
             return file.getName().endsWith(ESB_FILE_SUFFIX);

Modified: labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbRuntimeDeployer.java
===================================================================
--- labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbRuntimeDeployer.java	2008-12-01 14:58:33 UTC (rev 24183)
+++ labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/deployers/EsbRuntimeDeployer.java	2008-12-01 15:19:38 UTC (rev 24184)
@@ -29,9 +29,9 @@
 
 /**
  * EsbRuntimeDeployer takes care of the deployment of an {@link BeanMetaData} instance.
- * This deployer actually only created a BeanMetaData object describing a
- * {@link EsbDeployment}.
- *
+ * This deployer actually only creates a BeanMetaData object describing a
+ * {@link EsbDeployment}. The MicroContainer will take care of the actual creation
+ * and starting of the deployment using it's lifecycle callbacks.
  * <p/>
  *
  * @author <a href="mailto:dbevenius at jboss.com">Daniel Bevenius</a>
@@ -73,6 +73,7 @@
     {
         final BeanMetaData beanMetaData = createBeanMetaData(deploymentUnit, esbMetaData);
         deploymentUnit.addAttachment(BeanMetaData.class, beanMetaData);
+
         log.info("Created beanMetaData : " + beanMetaData);
     }
 

Modified: labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/metadata/EsbMetaData.java
===================================================================
--- labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/metadata/EsbMetaData.java	2008-12-01 14:58:33 UTC (rev 24183)
+++ labs/jbossesb/workspace/skeagh/container/microcontainer/src/main/java/org/jboss/esb/microcontainer/metadata/EsbMetaData.java	2008-12-01 15:19:38 UTC (rev 24184)
@@ -25,12 +25,12 @@
 import org.jboss.esb.deploy.config.DeploymentUnit;
 
 /**
- * Metadata for an ESB deployment constist of a {@link DeploymentUnit} and
+ * Metadata for an ESB deployment consists of a {@link DeploymentUnit} and
  * an archive name.
- * This metadata is intended by be created a a Deployment Parser. The parser
- * could read an xml configuration file, or could be generated in some
- * other way, perhaps using annotations on class files.
- * </p>
+ * <p/>
+ * This metadata is intended by be created a a Deployment Parser. A parser
+ * deployer could read an xml configuration file, or could be generated in some
+ * other way, perhaps using annotations on class files, another language, etc.
  *
  * @author <a href="mailto:dbevenius at jboss.com">Daniel Bevenius</a>
  * @since 5.0