[jboss-svn-commits] JBL Code SVN: r20976 - in labs/jbosstm/trunk: ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/resources/jts/orbspecific and 1 other directory.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Wed Jul 9 07:35:00 EDT 2008


Author: mark.little at jboss.com
Date: 2008-07-09 07:35:00 -0400 (Wed, 09 Jul 2008)
New Revision: 20976

Modified:
   labs/jbosstm/trunk/ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/resources/arjunacore/XAResourceRecord.java
   labs/jbosstm/trunk/ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/resources/jts/orbspecific/XAResourceRecord.java
Log:
http://jira.jboss.com/jira/browse/JBTM-377

Modified: labs/jbosstm/trunk/ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/resources/arjunacore/XAResourceRecord.java
===================================================================
--- labs/jbosstm/trunk/ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/resources/arjunacore/XAResourceRecord.java	2008-07-09 08:09:54 UTC (rev 20975)
+++ labs/jbosstm/trunk/ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/resources/arjunacore/XAResourceRecord.java	2008-07-09 11:35:00 UTC (rev 20976)
@@ -954,45 +954,37 @@
 			{
 				os.packInt(RecoverableXAConnection.OBJECT_RECOVERY);
 
-				boolean shouldSerialize = false;
-
-				try
-				{
-					if (_theXAResource instanceof Serializable)
-						shouldSerialize = true;
-
-					ByteArrayOutputStream s = new ByteArrayOutputStream();
-					ObjectOutputStream o = new ObjectOutputStream(s);
-
-					// don't allow the packing of a null resource
-
-					if (_theXAResource == null)
-						throw new NotSerializableException();
-
-					o.writeObject(_theXAResource);
-					o.close();
-
-					os.packBoolean(true);
-
-					os.packBytes(s.toByteArray());
-				}
-				catch (NotSerializableException ex)
-				{
-					if (!shouldSerialize)
-					{
-						// have to rely upon XAResource.recover!
-
-						os.packBoolean(false);
-					}
-					else
-					{
-						if (jtaLogger.loggerI18N.isWarnEnabled())
-						{
-							jtaLogger.loggerI18N
-									.warn("com.arjuna.ats.internal.jta.resources.arjunacore.savestate");
-						}
-					}
-				}
+                                if (_theXAResource instanceof Serializable)
+                                {
+        				try
+        				{
+        					ByteArrayOutputStream s = new ByteArrayOutputStream();
+        					ObjectOutputStream o = new ObjectOutputStream(s);
+        
+        					o.writeObject(_theXAResource);
+        					o.close();
+        
+        					os.packBoolean(true);
+        
+        					os.packBytes(s.toByteArray());
+        				}
+        				catch (NotSerializableException ex)
+        				{
+        				    if (jtaLogger.loggerI18N.isWarnEnabled())
+        				    {
+        				        jtaLogger.loggerI18N
+        				            .warn("com.arjuna.ats.internal.jta.resources.arjunacore.savestate");
+        				    }
+                                            
+                                            return false;
+        				}
+                                }
+                                else
+                                {
+                                    // have to rely upon XAResource.recover!
+                                    
+                                    os.packBoolean(false);
+                                }
 			}
 			else
 			{
@@ -1012,7 +1004,7 @@
 		}
 
 		if (res)
-			res = res && super.save_state(os, t);
+			res = super.save_state(os, t);
 
 		return res;
 	}
@@ -1102,9 +1094,7 @@
 						 * try to get a new XAResource later for this instance.
 						 */
 						
-						return true;
-						
-						//return false;
+						res = true;
 					}
 				}
 			}
@@ -1139,7 +1129,7 @@
 		}
 
 		if (res)
-			res = res && super.restore_state(os, t);
+			res = super.restore_state(os, t);
 
 		return res;
 	}

Modified: labs/jbosstm/trunk/ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/resources/jts/orbspecific/XAResourceRecord.java
===================================================================
--- labs/jbosstm/trunk/ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/resources/jts/orbspecific/XAResourceRecord.java	2008-07-09 08:09:54 UTC (rev 20975)
+++ labs/jbosstm/trunk/ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/resources/jts/orbspecific/XAResourceRecord.java	2008-07-09 11:35:00 UTC (rev 20976)
@@ -948,42 +948,37 @@
 			if (_recoveryObject == null)
 			{
 				os.packInt(RecoverableXAConnection.OBJECT_RECOVERY);
-
-				boolean shouldSerialize = false;
 				
-				try
-				{
-					if (_theXAResource instanceof Serializable)
-						shouldSerialize = true;
-					
-					ByteArrayOutputStream s = new ByteArrayOutputStream();
-					ObjectOutputStream o = new ObjectOutputStream(s);
+                                if (_theXAResource instanceof Serializable)
+                                {
+        				try
+        				{
+        					ByteArrayOutputStream s = new ByteArrayOutputStream();
+        					ObjectOutputStream o = new ObjectOutputStream(s);
+        
+        					o.writeObject(_theXAResource);
+        					o.close();
+        
+        					os.packBoolean(true);
+        
+        					os.packBytes(s.toByteArray());
+        				}
+        				catch (NotSerializableException ex)
+        				{
+        				    if (jtaLogger.loggerI18N.isWarnEnabled())
+        				    {
+        				        jtaLogger.loggerI18N.warn("com.arjuna.ats.internal.jta.resources.jts.orbspecific.saveState");
+        				    }
 
-					o.writeObject(_theXAResource);
-					o.close();
-
-					os.packBoolean(true);
-
-					os.packBytes(s.toByteArray());
-				}
-				catch (NotSerializableException ex)
-				{
-					if (!shouldSerialize)
-					{
-						// have to rely upon XAResource.recover!
-	
-						os.packBoolean(false);		
-					}			
-					else
-					{
-						if (jtaLogger.loggerI18N.isWarnEnabled())
-						{
-							jtaLogger.loggerI18N.warn("com.arjuna.ats.internal.jta.resources.jts.orbspecific.saveState");
-						}
-						
-						return false;
-					}
-				}
+        				    return false;
+        				}
+                                }
+                                else
+                                {
+                                    // have to rely upon XAResource.recover!
+                                
+                                    os.packBoolean(false);
+                                }
 			}
 			else
 			{




More information about the jboss-svn-commits mailing list