[jboss-svn-commits] JBL Code SVN: r20512 - in labs/jbossrules/trunk/drools-jbrms/src: test/java/org/drools/brms/server and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2008-06-16 03:48:08 -0400 (Mon, 16 Jun 2008)
New Revision: 20512

Modified:
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/ServiceImplementation.java
   labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java
Log:
small bug fix for caching binary rulebases

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/ServiceImplementation.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/ServiceImplementation.java	2008-06-16 07:42:44 UTC (rev 20511)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/ServiceImplementation.java	2008-06-16 07:48:08 UTC (rev 20512)
@@ -22,7 +22,6 @@
 import java.io.ObjectOutput;
 import java.text.DateFormat;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Calendar;
 import java.util.Collections;
 import java.util.Comparator;
@@ -135,7 +134,7 @@
     private static final Logger log = LoggingHelper.getLogger();
     private MetaDataMapper metaDataMapper = new MetaDataMapper();
 
-    /** Used for a simple cache of binary packages to avoid serialization from the database */
+    /** Used for a simple cache of binary packages to avoid serialization from the database - for test scenarios.*/
 	static Map<String, RuleBase> ruleBaseCache = Collections.synchronizedMap(new HashMap<String, RuleBase>());
 
     @WebRemote
@@ -919,7 +918,7 @@
 		item.updateBinaryUpToDate(true);
 		RuleBase rb = RuleBaseFactory.newRuleBase();
 		rb.addPackage(asm.getBinaryPackage());
-		this.ruleBaseCache.put(item.getUUID(), rb);
+		//this.ruleBaseCache.put(item.getUUID(), rb);
 	}
 
 

Modified: labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java	2008-06-16 07:42:44 UTC (rev 20511)
+++ labs/jbossrules/trunk/drools-jbrms/src/test/java/org/drools/brms/server/ServiceImplementationTest.java	2008-06-16 07:48:08 UTC (rev 20512)
@@ -1528,7 +1528,7 @@
 		assertTrue(pkg.getNode().getProperty("drools:binaryUpToDate")
 				.getBoolean());
 		assertTrue(pkg.isBinaryUpToDate());
-		assertTrue(impl.ruleBaseCache.containsKey(pkg.getUUID()));
+		assertFalse(impl.ruleBaseCache.containsKey(pkg.getUUID()));
 
 		RuleAsset asset = impl.loadRuleAsset(rule1.getUUID());
 		impl.checkinVersion(asset);
@@ -1541,7 +1541,7 @@
 
 		assertTrue(pkg.getNode().getProperty("drools:binaryUpToDate")
 				.getBoolean());
-		assertTrue(impl.ruleBaseCache.containsKey(pkg.getUUID()));
+		assertFalse(impl.ruleBaseCache.containsKey(pkg.getUUID()));
 
 		PackageConfigData config = impl.loadPackageConfig(pkg.getUUID());
 		impl.savePackage(config);