[jboss-svn-commits] JBL Code SVN: r18857 - labs/jbossrules/branches/4.0.x/drools-core/src/main/java/org/drools/reteoo.

[jboss-svn-commits at lists.jboss.org]

Author: tirelli
Date: 2008-03-11 18:50:59 -0400 (Tue, 11 Mar 2008)
New Revision: 18857

Modified:
   labs/jbossrules/branches/4.0.x/drools-core/src/main/java/org/drools/reteoo/ObjectTypeNode.java
Log:
JBRULES-1503: hacking up a bugged mechanism

Modified: labs/jbossrules/branches/4.0.x/drools-core/src/main/java/org/drools/reteoo/ObjectTypeNode.java
===================================================================
--- labs/jbossrules/branches/4.0.x/drools-core/src/main/java/org/drools/reteoo/ObjectTypeNode.java	2008-03-11 22:41:18 UTC (rev 18856)
+++ labs/jbossrules/branches/4.0.x/drools-core/src/main/java/org/drools/reteoo/ObjectTypeNode.java	2008-03-11 22:50:59 UTC (rev 18857)
@@ -301,23 +301,28 @@
      * @return
      */
     private boolean canSkipOnModify(final Sink[] sinks) {
+        // this mechanism is broken, so I'm disabling it for now
+        return false;
+
         // If we have no alpha or beta node with constraints on this ObjectType, we can just skip modifies
-        boolean hasConstraints = false;
-        for ( int i = 0; i < sinks.length && !hasConstraints; i++ ) {
-            if ( sinks[i] instanceof AlphaNode ) {
-                hasConstraints = this.usesDeclaration( ((AlphaNode) sinks[i]).getConstraint() );
-            } else if ( sinks[i] instanceof BetaNode && ((BetaNode) sinks[i]).getConstraints().length > 0 ) {
-                hasConstraints = this.usesDeclaration( ((BetaNode) sinks[i]).getConstraints() );
-            }
-            if ( !hasConstraints && sinks[i] instanceof ObjectSource ) {
-                hasConstraints = !this.canSkipOnModify( ((ObjectSource) sinks[i]).getSinkPropagator().getSinks() );
-            } else if ( sinks[i] instanceof TupleSource ) {
-                hasConstraints = !this.canSkipOnModify( ((TupleSource) sinks[i]).getSinkPropagator().getSinks() );
-            }
-        }
-
-        // Can only skip if we have no constraints
-        return !hasConstraints;
+//        boolean hasConstraints = false;
+//        for ( int i = 0; i < sinks.length && !hasConstraints; i++ ) {
+//            if ( sinks[i] instanceof AlphaNode ) {
+//                hasConstraints = this.usesDeclaration( ((AlphaNode) sinks[i]).getConstraint() );
+//            } else if ( sinks[i] instanceof BetaNode && ((BetaNode) sinks[i]).getConstraints().length > 0 ) {
+//                hasConstraints = this.usesDeclaration( ((BetaNode) sinks[i]).getConstraints() );
+//            }
+//            if ( !hasConstraints && sinks[i] instanceof ObjectSource ) {
+//                hasConstraints = !this.canSkipOnModify( ((ObjectSource) sinks[i]).getSinkPropagator().getSinks() );
+//            } else if ( sinks[i] instanceof TupleSource ) {
+//                hasConstraints = !this.canSkipOnModify( ((TupleSource) sinks[i]).getSinkPropagator().getSinks() );
+//            }
+//        }
+//
+//        // Can only skip if we have no constraints
+//        return !hasConstraints;
+        
+        
     }
 
     private boolean usesDeclaration(final Constraint[] constraints) {