[jboss-svn-commits] JBL Code SVN: r19228 - in labs/jbossrules/trunk/drools-core/src: test/java/org/drools/agent and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2008-03-25 21:47:21 -0400 (Tue, 25 Mar 2008)
New Revision: 19228

Modified:
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/URLScanner.java
   labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/MockListener.java
   labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/URLScannerTest.java
Log:
JBRULES-1528 URLScanner wasn't reporting IO exception causes to the log when falling back to local cache.

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/URLScanner.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/URLScanner.java	2008-03-26 00:49:04 UTC (rev 19227)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/URLScanner.java	2008-03-26 01:47:21 UTC (rev 19228)
@@ -90,11 +90,11 @@
             changes = getChangeSet();
             return changes;
         } catch ( IOException e ) {
+        	listener.exception( e );
             if (this.localCacheFileScanner != null) {
                 listener.warning( "Falling back to local cache." );
                 return localCacheFileScanner.loadPackageChanges();
             }
-            listener.exception( e );
         } catch ( ClassNotFoundException e ) {
             this.listener.exception( e );
             this.listener.warning( "Was unable to load a class when loading a package. Perhaps it is missing from this application." );

Modified: labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/MockListener.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/MockListener.java	2008-03-26 00:49:04 UTC (rev 19227)
+++ labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/MockListener.java	2008-03-26 01:47:21 UTC (rev 19228)
@@ -1,32 +1,37 @@
 package org.drools.agent;
 
+import java.util.ArrayList;
+import java.util.List;
+
 public class MockListener
     implements
     AgentEventListener {
 
+	public List exceptions = new ArrayList();
+
     public void debug(String message) {
-        
 
+
     }
 
     public void exception(Exception e) {
-        
+        exceptions.add(e);
 
     }
 
     public void info(String message) {
-        
 
+
     }
 
     public void setAgentName(String name) {
-        
 
+
     }
 
     public void warning(String message) {
-        
 
+
     }
 
 }

Modified: labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/URLScannerTest.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/URLScannerTest.java	2008-03-26 00:49:04 UTC (rev 19227)
+++ labs/jbossrules/trunk/drools-core/src/test/java/org/drools/agent/URLScannerTest.java	2008-03-26 01:47:21 UTC (rev 19228)
@@ -264,6 +264,7 @@
         Package[] changes = scan.loadPackageChanges();
         assertEquals(0, changes.length);
         assertEquals(true, fetchCalled[0]);
+        assertEquals(2, ((MockListener)scan.listener).exceptions.size());
 
     }