[jboss-svn-commits] JBL Code SVN: r20156 - labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files.

[jboss-svn-commits at lists.jboss.org]

Author: arhan
Date: 2008-05-24 15:29:07 -0400 (Sat, 24 May 2008)
New Revision: 20156

Modified:
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/AssetFileServlet.java
   labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/WebDAVImpl.java
Log:
minor changes

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/AssetFileServlet.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/AssetFileServlet.java	2008-05-24 18:01:50 UTC (rev 20155)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/AssetFileServlet.java	2008-05-24 19:29:07 UTC (rev 20156)
@@ -47,7 +47,7 @@
                                                        IOException {
 
         response.setContentType( "text/html" );
-        FormData uploadItem = new FileManagerUtils().getFormData( request );
+        FormData uploadItem = FileManagerUtils.getFormData( request );
 
         if ( uploadItem.getFile() != null && uploadItem.getUuid() != null ) {
             //attaching to an asset.
@@ -66,13 +66,12 @@
                          HttpServletResponse res) throws ServletException,
                                                  IOException {
 
-        String uuid = (String) req.getParameter( HTMLFileManagerFields.FORM_FIELD_UUID );
+        String uuid = req.getParameter( HTMLFileManagerFields.FORM_FIELD_UUID );
 
         if ( uuid != null ) {
             processAttachmentDownload( uuid, res );
         } else {
             res.sendError( HttpServletResponse.SC_BAD_REQUEST );
-            return;
         }
     }
 

Modified: labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/WebDAVImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/WebDAVImpl.java	2008-05-24 18:01:50 UTC (rev 20155)
+++ labs/jbossrules/trunk/drools-jbrms/src/main/java/org/drools/brms/server/files/WebDAVImpl.java	2008-05-24 19:29:07 UTC (rev 20156)
@@ -27,7 +27,7 @@
 	/** for the rubbish OSX double data (the ._ rubbish) */
 	static Map<String, byte[]> osxDoubleData = Collections.synchronizedMap(new WeakHashMap<String, byte[]>());
 
-    final ThreadLocal<RulesRepository> tlRepo = new ThreadLocal<RulesRepository>();;
+    final ThreadLocal<RulesRepository> tlRepo = new ThreadLocal<RulesRepository>();
 
 
     public WebDAVImpl(File f) {
@@ -392,11 +392,7 @@
     boolean shouldCreateNewVersion(Calendar lastModified) {
         Calendar now = Calendar.getInstance();
         int diff = 3600000; //1 hour
-        if (now.getTimeInMillis() - lastModified.getTimeInMillis() > diff) {
-            return true;
-        } else {
-            return false;
-        }
+        return (now.getTimeInMillis() - lastModified.getTimeInMillis()) > diff;
     }
 
     String[] getPath(String uri) {