[jboss-svn-commits] JBL Code SVN: r23971 - labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server.

[jboss-svn-commits at lists.jboss.org]

Author: jamesdeanturner
Date: 2008-11-19 12:27:25 -0500 (Wed, 19 Nov 2008)
New Revision: 23971

Modified:
   labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java
Log:
added constant to express max rules in list via package

Modified: labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java
===================================================================
--- labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java	2008-11-19 17:26:57 UTC (rev 23970)
+++ labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java	2008-11-19 17:27:25 UTC (rev 23971)
@@ -144,6 +144,11 @@
     implements
     RepositoryService {
 
+	/**
+	 * Maximum number of rules to display in "list rules in package" method
+	 */
+	private static final int MAX_RULES_TO_SHOW_IN_PACKAGE_LIST = 5000;
+	
     @In
     public RulesRepository          repository;
 
@@ -1630,12 +1635,16 @@
     @WebRemote
     @Restrict("#{identity.loggedIn}")
     public String[] listRulesInPackage(String packageName) throws SerializableException {
+    	
+    	// check security
         if ( Contexts.isSessionContextActive() ) {
             Identity.instance().checkPermission( new PackageNameType( packageName ),
                                                  RoleTypes.PACKAGE_READONLY );
         }
 
+        // load package
         PackageItem item = repository.loadPackage( packageName );
+        
         ContentPackageAssembler asm = new ContentPackageAssembler( item,
                                                                    false );
         List<String> result = new ArrayList<String>();
@@ -1648,8 +1657,8 @@
                     RuleDescr r = (RuleDescr) iterator.next();
                     result.add( r.getName() );
                     count++;
-                    if ( count == 5000 ) {
-                        result.add( "More then 5000 rules." );
+					if (count == MAX_RULES_TO_SHOW_IN_PACKAGE_LIST) {
+						result.add("More then " + MAX_RULES_TO_SHOW_IN_PACKAGE_LIST + " rules.");
                         break;
                     }
                 }