[jboss-svn-commits] JBL Code SVN: r24010 - labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server.

[jboss-svn-commits at lists.jboss.org]

Author: Rikkola
Date: 2008-11-20 17:28:34 -0500 (Thu, 20 Nov 2008)
New Revision: 24010

Modified:
   labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java
Log:
JBRULES-1851: analyst.readonly role is broken

Modified: labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java
===================================================================
--- labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java	2008-11-20 21:10:04 UTC (rev 24009)
+++ labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/ServiceImplementation.java	2008-11-20 22:28:34 UTC (rev 24010)
@@ -367,13 +367,16 @@
         if ( Contexts.isSessionContextActive() ) {
             if ( !Identity.instance().hasPermission( new CategoryPathType( categoryPath ),
                                                      RoleTypes.ANALYST_READ ) ) {
+                
                 TableDisplayHandler handler = new TableDisplayHandler( tableConfig );
                 return handler.loadRuleListTable( new AssetPageList() );
             }
         }
-
+        
         //use AssetItemFilter to enforce package-based permissions.
-        RepositoryFilter filter = new AssetItemFilter();
+//        RepositoryFilter filter = new AssetItemFilter();
+        // Filter is null since the permission is checked on category level.
+        RepositoryFilter filter = null;
         AssetPageList list = repository.findAssetsByCategory( categoryPath,
                                                               false,
                                                               skip,