[jboss-svn-commits] JBL Code SVN: r22320 - in labs/jbossrules/trunk/drools-compiler/src: test/java/org/drools/lang and 1 other directory.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Tue Sep 2 09:19:30 EDT 2008


Author: porcelli
Date: 2008-09-02 09:19:30 -0400 (Tue, 02 Sep 2008)
New Revision: 22320

Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/DRLIncompleteCodeTest.java
Log:
JBRULES-1689: in editor mode the DrlParser do not generate exceptions, just returns null.

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java	2008-09-02 12:48:54 UTC (rev 22319)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java	2008-09-02 13:19:30 UTC (rev 22320)
@@ -205,9 +205,13 @@
 				return null;
 			}
 		} catch (Exception e) {
-			throw new DroolsParserException(
-					"Unknown error while parsing. This is a bug. Please contact the Development team.",
-					e);
+			if (isEditor) {
+				return null;
+			} else {
+				throw new DroolsParserException(
+						"Unknown error while parsing. This is a bug. Please contact the Development team.",
+						e);
+			}
 		}
 	}
 

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/DRLIncompleteCodeTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/DRLIncompleteCodeTest.java	2008-09-02 12:48:54 UTC (rev 22319)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/DRLIncompleteCodeTest.java	2008-09-02 13:19:30 UTC (rev 22320)
@@ -180,14 +180,12 @@
 			"end ";
 		DrlParser parser = new DrlParser();
 		PackageDescr descr = parser.parse(true, input);
-		assertNotNull(descr);
-		assertEquals("a.b.c", descr.getNamespace());
-		assertEquals("a.b.c.*", ((ImportDescr) descr.getImports().get(0)).getTarget());
+		assertNull(descr);
 	}
 	
 	@SuppressWarnings("unchecked")
 	private int getLastIntegerValue(LinkedList list) {
-		System.out.println(list.toString());
+//		System.out.println(list.toString());
 		int lastIntergerValue = -1;
 		for (Object object : list) {
 			if (object instanceof Integer) {




More information about the jboss-svn-commits mailing list