[jboss-svn-commits] JBL Code SVN: r22888 - in labs/jbossesb/workspace/skeagh: routing/jms/src/main/java/org/jboss/esb/jms and 7 other directories.
jboss-svn-commits at lists.jboss.org
jboss-svn-commits at lists.jboss.org
Thu Sep 18 13:01:32 EDT 2008
Author: tfennelly
Date: 2008-09-18 13:01:32 -0400 (Thu, 18 Sep 2008)
New Revision: 22888
Modified:
labs/jbossesb/workspace/skeagh/commons/src/main/java/org/jboss/esb/jms/AbstractMessageListener.java
labs/jbossesb/workspace/skeagh/routing/jms/src/main/java/org/jboss/esb/jms/JmsInboundRouter.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/DeploymentRuntime.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/DeploymentUnit.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/PropertiesUtil.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/CreateObject.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/FieldListAccessor.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/SetProperty.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/dispatch/AbstractDispatcher.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/DeploymentCoordinator.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/Bus.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusDispatcher.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusInboundRouter.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusMessage.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusOutboundRouter.java
labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/jms/JMSBus.java
Log:
checkstyle fixes
Modified: labs/jbossesb/workspace/skeagh/commons/src/main/java/org/jboss/esb/jms/AbstractMessageListener.java
===================================================================
--- labs/jbossesb/workspace/skeagh/commons/src/main/java/org/jboss/esb/jms/AbstractMessageListener.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/commons/src/main/java/org/jboss/esb/jms/AbstractMessageListener.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -100,7 +100,7 @@
{
boolean noLocal = !properties.getProperty(NO_LOCAL, "true").equals("false");
- // A null 'messageSelector' is valid i.e. no selector on the consumer. 'noLocal' is on by default...
+ // A null 'messageSelector' is valid i.e. no selector on the consumer. 'noLocal' is on by default...
messageConsumer = ((TopicSession) getSession()).createSubscriber((Topic) getDestination(), messageSelector, noLocal);
messageConsumer.setMessageListener(this);
}
Modified: labs/jbossesb/workspace/skeagh/routing/jms/src/main/java/org/jboss/esb/jms/JmsInboundRouter.java
===================================================================
--- labs/jbossesb/workspace/skeagh/routing/jms/src/main/java/org/jboss/esb/jms/JmsInboundRouter.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/routing/jms/src/main/java/org/jboss/esb/jms/JmsInboundRouter.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -77,7 +77,7 @@
private MessageDispatcher dispatcher;
/**
- * Deployment context
+ * Deployment context.
*/
@SuppressWarnings("unused")
private DeploymentContext deploymentContext;
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/DeploymentRuntime.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/DeploymentRuntime.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/DeploymentRuntime.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -460,7 +460,6 @@
try
{
SimpleSchedule heartbeatSchedule = new SimpleSchedule();
- ApplicationProperties deploymentProperties = PropertiesUtil.getDeploymentConfig(deploymentName);
heartbeatSchedule.setFrequency(deploymentProperties.getLongProperty(DeploymentCoordinator.COORDINATOR_HEARTBEAT_FREQUENCY_KEY, DeploymentCoordinator.COORDINATOR_HEARTBEAT_DEFAULT_FREQUENCY));
heartbeatSchedule.setExecCount(-1);
@@ -552,7 +551,7 @@
*
* @param busRouters The Map to which the routers are to be added.
*/
- public void addBusOutboundRouters(Map<ServiceName, BusOutboundRouter> busRouters)
+ public final void addBusOutboundRouters(final Map<ServiceName, BusOutboundRouter> busRouters)
{
Set<Map.Entry<ServiceName, List<OutboundRouterConfig>>> outRouters = aggregatedDeploymentUnit.getOutboundRouters().entrySet();
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/DeploymentUnit.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/DeploymentUnit.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/DeploymentUnit.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -264,9 +264,9 @@
{
// Check through the inrouter definitions...
Set<Map.Entry<ServiceName, List<InboundRouterConfig>>> inrouterLists = inboundRouters.entrySet();
- for (Map.Entry<ServiceName,List<InboundRouterConfig>> inrouterList : inrouterLists)
+ for (Map.Entry<ServiceName, List<InboundRouterConfig>> inrouterList : inrouterLists)
{
- if(!outboundRouters.containsKey(inrouterList.getKey()))
+ if (!outboundRouters.containsKey(inrouterList.getKey()))
{
outboundRouters.put(inrouterList.getKey(), new ArrayList<OutboundRouterConfig>());
}
@@ -276,7 +276,7 @@
Set<Map.Entry<ServiceName, ServiceConfig>> serviceList = services.entrySet();
for (Map.Entry<ServiceName, ServiceConfig> service : serviceList)
{
- if(!outboundRouters.containsKey(service.getKey()))
+ if (!outboundRouters.containsKey(service.getKey()))
{
outboundRouters.put(service.getKey(), new ArrayList<OutboundRouterConfig>());
}
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/PropertiesUtil.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/PropertiesUtil.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/PropertiesUtil.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -121,7 +121,7 @@
* The default configuration is overlayed with the deployment specific configuration.
* <p/>
* <b><u>NOTE:</u></b> The deployment name is URL encoded (application/x-www-form-urlencoded).
- *
+ *
* @param deploymentName The deployment name.
* @return The main Deployment properties.
* @throws DeploymentException Error reading properties.
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/CreateObject.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/CreateObject.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/CreateObject.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -20,13 +20,6 @@
package org.jboss.esb.deploy.config.digest;
import static org.jboss.esb.annotations.AnnotationConstants.UNASSIGNED;
-
-import java.lang.reflect.Constructor;
-import java.lang.reflect.Field;
-import java.util.ArrayList;
-import java.util.List;
-
-import org.apache.log4j.Logger;
import org.jboss.esb.annotations.Property;
import org.jboss.esb.annotations.Property.Use;
import org.jboss.esb.classpath.ClassUtil;
@@ -42,6 +35,11 @@
import org.milyn.xml.DomUtils;
import org.w3c.dom.Element;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.Field;
+import java.util.ArrayList;
+import java.util.List;
+
/**
* Create an object and set it in the Smooks bean repository.
*
@@ -49,7 +47,6 @@
*/
public class CreateObject implements DOMVisitBefore, DOMVisitAfter
{
- private Logger log = Logger.getLogger(CreateObject.class);
/**
* The name of the class.
@@ -196,7 +193,6 @@
* <p/>
* @param hierarchyClass The Class hierarchy level to be checked
* @param instance The object instance
- * @param properties The config properties
* @param setFields List containing the fields that have been set(that existed in the config)
*/
final void checkFieldAnnoations(final Class<?> hierarchyClass, final Object instance, final List<Field> setFields)
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/FieldListAccessor.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/FieldListAccessor.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/FieldListAccessor.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -20,12 +20,12 @@
*/
package org.jboss.esb.deploy.config.digest;
+import org.jboss.esb.util.AssertArgument;
+import org.milyn.container.ExecutionContext;
+
import java.lang.reflect.Field;
import java.util.List;
-import org.jboss.esb.util.AssertArgument;
-import org.milyn.container.ExecutionContext;
-
/**
* Helper class to access the list of Fields that have been
* configured.
@@ -35,8 +35,14 @@
*/
public final class FieldListAccessor
{
+ /**
+ * Properties Key.
+ */
private static final String PROPERTIES_KEY = "#properties:";
+ /**
+ * Private default constructor.
+ */
private FieldListAccessor()
{
}
@@ -46,7 +52,7 @@
*
* @param executionContext - the Smooks execution context
* @param beanId - the beanId to look up
- * @return List<Field> - a list of fields. The fields being the fields found in a configuration file
+ * @return A list of fields. The fields being the fields found in a configuration file
*/
@SuppressWarnings("unchecked")
public static List<Field> get(final ExecutionContext executionContext, final String beanId)
@@ -74,7 +80,7 @@
}
/**
- * Removes the list associated with the passed in beanId
+ * Removes the list associated with the passed in beanId.
* @param executionContext - the Smooks execution context
* @param beanId - the beanId to look up
*/
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/SetProperty.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/SetProperty.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/deploy/config/digest/SetProperty.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -19,12 +19,6 @@
*/
package org.jboss.esb.deploy.config.digest;
-import java.lang.reflect.Field;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
-
import org.jboss.esb.annotations.AnnotationConstants;
import org.jboss.esb.annotations.Property;
import org.jboss.esb.classpath.ClassUtil;
@@ -37,6 +31,12 @@
import org.milyn.xml.DomUtils;
import org.w3c.dom.Element;
+import java.lang.reflect.Field;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
/**
* Set the value of a property of a bean (from the Smooks bean repository).
*
@@ -112,9 +112,11 @@
*
* @param clazz Class object on which the field should be set. Needed to be
* able to find superclasses.
- * @param instance the instance that contains the field to be set
- * @param configPropertyName the name of the configuration property
- * @param value the value to set the field to
+ * @param instance the instance that contains the field to be set.
+ * @param configPropertyName the name of the configuration property.
+ * @param value the value to set the field to.
+ * @param fieldsList The field list to be added t if the field is set.
+ * @return True if the field was set, otherwise false.
* @throws IllegalAccessException if the field was not accessible.
*/
final boolean attemptAnnotationFieldSet(
@@ -153,6 +155,16 @@
return fieldSet;
}
+ /**
+ * Will set the value of the instance field annotated with {@link Properties}.
+ *
+ * @param clazz Class object on which the field should be set. Needed to be
+ * able to find superclasses.
+ * @param instance the instance that contains the field to be set.
+ * @param configPropertyName the name of the configuration property.
+ * @param value the value to set the field to.
+ * @throws IllegalAccessException if the field was not accessible.
+ */
final void attemptAnnotationPropertySet(
final Class<?> clazz,
final Object instance,
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/dispatch/AbstractDispatcher.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/dispatch/AbstractDispatcher.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/dispatch/AbstractDispatcher.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -22,14 +22,14 @@
import org.jboss.esb.context.AddressingContext;
import org.jboss.esb.context.DeploymentContext;
import org.jboss.esb.deploy.config.OutboundRouterConfig;
+import org.jboss.esb.federate.bus.BusOutboundRouter;
import org.jboss.esb.message.Message;
import org.jboss.esb.message.MessageTransformer;
import org.jboss.esb.routing.MessageDispatcher;
+import org.jboss.esb.routing.OutboundRouter;
import org.jboss.esb.routing.RoutingException;
-import org.jboss.esb.routing.OutboundRouter;
import org.jboss.esb.service.Service;
import org.jboss.esb.service.ServiceName;
-import org.jboss.esb.federate.bus.BusOutboundRouter;
import java.util.List;
@@ -178,14 +178,14 @@
// If this deployment doesn't specifiy this service, see is there a
// Service by this name on one of the monitored deployments, and route
// it there...
- if(!getServiceName().equals(addressContext.getFrom()))
+ if (!getServiceName().equals(addressContext.getFrom()))
{
for (OutboundRouterConfig outboundRouterConfig : outboundRouters)
{
OutboundRouter outRouter = outboundRouterConfig.getRouter();
- if(outRouter instanceof BusOutboundRouter)
+ if (outRouter instanceof BusOutboundRouter)
{
- if(((BusOutboundRouter)outRouter).hasService(serviceName))
+ if (((BusOutboundRouter) outRouter).hasService(serviceName))
{
outRouter.route(outMessage);
// In this case, we don't pass the message to the other outrouters (below).
@@ -200,9 +200,9 @@
for (OutboundRouterConfig outboundRouter : outboundRouters)
{
OutboundRouter outRouter = outboundRouter.getRouter();
- if(outRouter instanceof BusOutboundRouter)
+ if (outRouter instanceof BusOutboundRouter)
{
- if(!((BusOutboundRouter)outRouter).hasService(serviceName))
+ if (!((BusOutboundRouter) outRouter).hasService(serviceName))
{
outRouter.route(outMessage);
}
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/DeploymentCoordinator.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/DeploymentCoordinator.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/DeploymentCoordinator.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -372,11 +372,6 @@
return bus;
}
- public NotificationListener getNotificationListener()
- {
- return notificationListener;
- }
-
/**
* Get all active Deployment Monitors for this Bus deployment.
*
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/Bus.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/Bus.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/Bus.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -113,16 +113,23 @@
/**
* Bus Factory class.
*/
- public static class Factory
+ public final class Factory
{
/**
+ * Private default constructor.
+ */
+ private Factory()
+ {
+ }
+
+ /**
* New Bus instance.
*
* @param className Bus class name.
* @return Bus instance.
* @throws DeploymentException Error creating Bus instance.
*/
- public static Bus newInstance(String className) throws DeploymentException
+ public static Bus newInstance(final String className) throws DeploymentException
{
try
{
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusDispatcher.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusDispatcher.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusDispatcher.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -43,7 +43,7 @@
*
* @param deploymentContext The deployment context with which this
* dispatcher is associated.
- */
+ */
public BusDispatcher(final DeploymentContext deploymentContext)
{
super(deploymentContext);
@@ -56,7 +56,7 @@
* @param invocationContext The InvocationContext for the message dispatch.
* @throws RoutingException An exception occured while dispatching the message.
*/
- public void dispatch(final Message message, final InvocationContext invocationContext) throws RoutingException
+ public final void dispatch(final Message message, final InvocationContext invocationContext) throws RoutingException
{
AssertArgument.isNotNull(message, "message");
AssertArgument.isNotNull(invocationContext, "invocationContext");
@@ -68,7 +68,7 @@
// The addressing context should have been set for
// this dispacther. It should have been received from the Bus...
AddressingContext addressingContext = AddressingContext.getContext();
- if(addressingContext == null)
+ if (addressingContext == null)
{
throw new IllegalStateException("Null AddressingContext set on BusMessage instance.");
}
@@ -82,7 +82,7 @@
// Only pass the message to the service if the from address
// is null (i.e. it's from an InRouter or client), or it is from
// a different service....
- if(from == null || !from.equals(getServiceName()))
+ if (from == null || !from.equals(getServiceName()))
{
outMessage = dispatchToService(message);
}
@@ -93,11 +93,13 @@
applyOutboundRouters(outMessage);
// TODO; Use the faultTo address if there's an issue??
- } finally
+ }
+ finally
{
InvocationContext.setContext(null);
}
- } finally
+ }
+ finally
{
DeploymentContext.setContext(null);
}
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusInboundRouter.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusInboundRouter.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusInboundRouter.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -19,12 +19,12 @@
*/
package org.jboss.esb.federate.bus;
+import org.jboss.esb.context.AddressingContext;
+import org.jboss.esb.context.InvocationContext;
+import org.jboss.esb.message.Message;
import org.jboss.esb.routing.InboundRouter;
import org.jboss.esb.routing.MessageDispatcher;
import org.jboss.esb.routing.RoutingException;
-import org.jboss.esb.context.InvocationContext;
-import org.jboss.esb.context.AddressingContext;
-import org.jboss.esb.message.Message;
/**
* Bus inbound router for a specific Service.
@@ -51,9 +51,15 @@
this.dispatcher = dispatcher;
}
+ /**
+ * Receive a message from a {@link Bus}.
+ *
+ * @param busMessage The bus message.
+ * @throws RoutingException Error processing the message routed via the Bus.
+ */
public final void receive(final BusMessage busMessage) throws RoutingException
{
- if(dispatcher == null)
+ if (dispatcher == null)
{
throw new IllegalStateException("Message Dispatcher instance not set on router instance.");
}
@@ -66,7 +72,8 @@
try
{
dispatcher.dispatch(esbMessage, invocationContext);
- } finally
+ }
+ finally
{
AddressingContext.setContext(null);
}
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusMessage.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusMessage.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusMessage.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -57,7 +57,7 @@
*
* @return The invocation parameters.
*/
- public final Map<String, String> getInvocationParameters()
+ public Map<String, String> getInvocationParameters()
{
return invocationParameters;
}
@@ -70,13 +70,14 @@
*
* @param invocationParameters The invocation parameters.
*/
- public void setInvocationParameters(Map<String, String> invocationParameters)
+ public void setInvocationParameters(final Map<String, String> invocationParameters)
{
this.invocationParameters = invocationParameters;
}
/**
* Get the message Addressing Context.
+ *
* @return The message Addressing Context.
*/
public AddressingContext getAddressingContext()
@@ -86,6 +87,7 @@
/**
* Set the message Addressing Context.
+ *
* @param addressingContext The message Addressing Context.
*/
public void setAddressingContext(final AddressingContext addressingContext)
@@ -95,6 +97,7 @@
/**
* Get the message.
+ *
* @return The message.
*/
public Message getMessage()
@@ -104,6 +107,7 @@
/**
* Set the message.
+ *
* @param message The message.
*/
public void setMessage(final Message message)
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusOutboundRouter.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusOutboundRouter.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/BusOutboundRouter.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -208,21 +208,21 @@
* Does this bus router have an active monitor for a deployment
* that has the specifid service.
*
- * @param serviceName The Service name.
+ * @param service The Service name.
* @return True if this router has an active monitor for a deployment
- * that has the specifid service.
+ * that has the specifid service.
*/
- public final boolean hasService(final ServiceName serviceName)
+ public final boolean hasService(final ServiceName service)
{
for (DeploymentMonitor deploymentMonitor : deploymentMonitors)
{
// Purposely not checking the monitor's online status!
- if(deploymentMonitor.hasService(serviceName))
+ if (deploymentMonitor.hasService(service))
{
return true;
}
}
-
+
return false;
}
}
Modified: labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/jms/JMSBus.java
===================================================================
--- labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/jms/JMSBus.java 2008-09-18 16:52:49 UTC (rev 22887)
+++ labs/jbossesb/workspace/skeagh/runtime/src/main/java/org/jboss/esb/federate/bus/jms/JMSBus.java 2008-09-18 17:01:32 UTC (rev 22888)
@@ -557,7 +557,7 @@
{
busMessageCallback.onMessage((BusMessage) objectMessage);
}
- catch(RoutingException e)
+ catch (RoutingException e)
{
logger.error("Error processing ESB Message: " + objectMessage, e);
}
More information about the jboss-svn-commits
mailing list