[jboss-svn-commits] JBL Code SVN: r23126 - in labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb: notification and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: mark.little at jboss.com
Date: 2008-09-27 17:12:44 -0400 (Sat, 27 Sep 2008)
New Revision: 23126

Modified:
   labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java
   labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/notification/NotifySqlTable.java
Log:
https://jira.jboss.org/jira/browse/JBESB-1887

Modified: labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java
===================================================================
--- labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java	2008-09-27 10:55:25 UTC (rev 23125)
+++ labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/listeners/gateway/SqlTableGatewayListener.java	2008-09-27 21:12:44 UTC (rev 23126)
@@ -755,6 +755,16 @@
                     _logger.warn("Cannot change row state from " + fromState
                             + " to " + toState + ".  Number of rows in state "
                             + fromState + " = " + count);
+                    
+                    if (count == 0)  // the execute affected zero rows!
+                    {
+                        // https://jira.jboss.org/jira/browse/SOA-642
+                        
+                        _logger.warn("No rows affected by update statement. Check listener/gateway/notifier table definitions are correct.");
+                    }
+                    else
+                        _logger.warn("Curent implementation expected only one row to be applicable to update request.");
+                    
                     return false;
                 }
             }

Modified: labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/notification/NotifySqlTable.java
===================================================================
--- labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/notification/NotifySqlTable.java	2008-09-27 10:55:25 UTC (rev 23125)
+++ labs/jbossesb/branches/JBESB_4_4_GA_CP/product/rosetta/src/org/jboss/soa/esb/notification/NotifySqlTable.java	2008-09-27 21:12:44 UTC (rev 23126)
@@ -167,6 +167,7 @@
 			oConn = createJdbcCleanConnection();
 			ps = oConn.prepareStatement(getInsertStmt());
 			oConn.execUpdWait(ps, 3);
+			// TODO the executeUpdate routine doesn't check return code, which could mask a problem https://jira.jboss.org/jira/browse/SOA-642
 			oConn.commit();
 		} 
 		catch( SQLException e)