[jboss-svn-commits] JBoss Common SVN: r3476 - declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base.

[jboss-svn-commits at lists.jboss.org]

Author: johnbailey
Date: 2009-08-23 14:18:47 -0400 (Sun, 23 Aug 2009)
New Revision: 3476

Modified:
   declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveBase.java
   declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveImpl.java
Log:
[TMPARCH-9] - 1.  Documented thread safety in MemoryMapArchiveBase/Impl.  2.  Removed comparator from MemoryMapArchiveBase toString.

Modified: declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveBase.java
===================================================================
--- declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveBase.java	2009-08-23 17:49:44 UTC (rev 3475)
+++ declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveBase.java	2009-08-23 18:18:47 UTC (rev 3476)
@@ -18,7 +18,6 @@
 
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.Comparator;
 import java.util.List;
 import java.util.Map;
 import java.util.UUID;
@@ -37,7 +36,7 @@
 /**
  * MemoryMapArchiveBase
  * 
- * A base implementation for all MemoryMap archives
+ * A base implementation for all MemoryMap archives. Thread-safe.
  *
  * @author <a href="mailto:baileyje at gmail.com">John Bailey</a>
  * @author <a href="mailto:aslak at conduct.no">Aslak Knutsen</a>
@@ -261,17 +260,8 @@
    {
       StringBuilder sb = new StringBuilder();
       List<Path> paths = new ArrayList<Path>(content.keySet());
-      // TODO: Make sure Paths impl Comparable
-      Collections.sort(paths, new Comparator<Path>()
-      {
-         @Override
-         public int compare(Path path1, Path path2)
-         {
-            return path1.get().compareTo(path2.get());
-         }
+      Collections.sort(paths);
 
-      });
-
       for (Path path : paths)
       {
          sb.append(path.get()).append('\n');

Modified: declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveImpl.java
===================================================================
--- declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveImpl.java	2009-08-23 17:49:44 UTC (rev 3475)
+++ declarchive/trunk/impl-base/src/main/java/org/jboss/declarchive/impl/base/MemoryMapArchiveImpl.java	2009-08-23 18:18:47 UTC (rev 3476)
@@ -22,7 +22,7 @@
 /**
  * MemoryMapArchiveImpl
  * 
- * A default implementation for all MemoryMap archives.
+ * A default implementation for all MemoryMap archives. Thread-safe.
  *
  * @author <a href="mailto:baileyje at gmail.com">John Bailey</a>
  * @version $Revision: $