[jboss-svn-commits] JBL Code SVN: r29110 - labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences.

[jboss-svn-commits at lists.jboss.org]

Author: KrisVerlaenen
Date: 2009-08-28 09:26:09 -0400 (Fri, 28 Aug 2009)
New Revision: 29110

Modified:
   labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesBlock.java
   labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesPreferencePage.java
Log:
JBIDE-4720: There is no way to leave 'Installed Drools Runtime' Preference page if there is no configured runtimes
 - allowing to save invalid/incomplete settings, showing error message only

Modified: labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesBlock.java
===================================================================
--- labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesBlock.java	2009-08-28 12:59:34 UTC (rev 29109)
+++ labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesBlock.java	2009-08-28 13:26:09 UTC (rev 29110)
@@ -211,11 +211,7 @@
 		IStructuredSelection selection = (IStructuredSelection) droolsRuntimesList.getSelection();
 		int selectionCount= selection.size();
 		fEditButton.setEnabled(selectionCount == 1);
-		if (selectionCount > 0 && selectionCount < droolsRuntimesList.getTable().getItemCount()) {
-			fRemoveButton.setEnabled(true);
-		} else {
-			fRemoveButton.setEnabled(false);
-		}
+		fRemoveButton.setEnabled(selectionCount > 0);
 	}
 	
 	public Control getControl() {

Modified: labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesPreferencePage.java
===================================================================
--- labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesPreferencePage.java	2009-08-28 12:59:34 UTC (rev 29109)
+++ labs/jbossrules/trunk/drools-eclipse/org.drools.eclipse/src/main/java/org/drools/eclipse/preferences/DroolsRuntimesPreferencePage.java	2009-08-28 13:26:09 UTC (rev 29110)
@@ -59,7 +59,6 @@
 			}
 		}
 		if (droolsRuntimesBlock.getDefaultDroolsRuntime() == null) {
-			setValid(false);
 			setErrorMessage("Select a default Drools Runtime");
 		}
 		Control control = droolsRuntimesBlock.getControl();
@@ -72,10 +71,8 @@
 			public void selectionChanged(SelectionChangedEvent event) {
 				DroolsRuntime runtime = droolsRuntimesBlock.getDefaultDroolsRuntime();
 				if (runtime == null) {
-					setValid(false);
 					setErrorMessage("Select a default Drools Runtime"); 
 				} else {
-					setValid(true);
 					setErrorMessage(null);
 				}
 			}